CI: RuboCop as a Build Stage before tests run #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #870 for comparison. |
olleolleolle
force-pushed
the
add-ci-check
branch
4 times, most recently
from
47b33fb to
80359c0
Compare
technoweenie
requested changes
Feb 25, 2019
There was a problem hiding this comment.
Nice, I like the separate Travis build step. I'd remove the rubocop check in codeclimate too, since it runs on an old version of rubocop.
olleolleolle
changed the title
|
Full disclosure: CodeClimate runs "channels" of versions of RuboCop: This allows one to pick a version family, using the |
|
The furious pace of RuboCop releases is hard to keep up with – also for CodeClimate. 0.64 is the latest of their Channels. 0.65.0 is the latest RuboCop release. |
- disable the not-always recent CodeClimate RuboCop plugin
olleolleolle
force-pushed
the
add-ci-check
branch
from
4aec156 to
fda0480
Compare
technoweenie
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR frontloads RuboCop checks onto the default Rake task.This PR adds a TravisCI Build Stage
linting, which installsrubocopand runs it.If that stage fails, no virtual machines with the RSpec tests are even booted.
We use this way, in order to keep up with latest RuboCop releases, since CodeClimate's built-in is a good few versions behind.