Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local album art #568

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: local album art #568

merged 3 commits into from
Oct 11, 2024

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Oct 11, 2024

Summary by CodeRabbit

  • New Features

    • Added new themes to enhance user customization options, featuring unique attributes and multimedia elements.
    • Introduced a new function for building a browsing tree for media playlists on Android platforms.
  • Bug Fixes

    • Improved error handling in the album art fetching process.
  • Refactor

    • Streamlined media fetching workflows and updated state management in components.
  • Documentation

    • Updated dependency versions to ensure compatibility and incorporate improvements.
  • Style

    • Renamed functions and variables for consistency and clarity.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 2:30pm

@lovegaoshi lovegaoshi merged commit 93d6561 into master Oct 11, 2024
3 of 5 checks passed
Copy link

coderabbitai bot commented Oct 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes updates to the package.json file, modifying various dependencies and development dependencies for the azusa-player-mobile project. Significant changes involve version increments for the expo package and updates to commit references for react-native-track-player and ytdl-core. Additionally, several development dependencies, such as Babel and TypeScript, have been updated. Other files reflect changes in state management, function signatures, and error handling, enhancing functionality and maintaining compatibility across components.

Changes

File Path Change Summary
package.json Updated dependencies: expo (to ^51.0.37), react-native-track-player (commit updated), ytdl-core (commit updated). Updated devDependencies: @babel/core, @babel/plugin-transform-export-namespace-from, @babel/preset-env, @types/node, typescript.
src/components/player/TrackInfo/AlbumArt.tsx Changed state variable type from string to `string
src/components/styles/steriaGarb.json Added multiple new themes with attributes including themeName, themeDesc, themeAuthor, themeIcon, and darkTheme.
src/hooks/usePlaybackAA.ts Introduced buildBrowseTree function for Android platforms; updated useAndroidAuto to use this new function.
src/hooks/useSetupPlayer.ts Renamed AdditionalPlaybackService to additionalPlaybackService; added playlists parameter to initializePlayer.
src/hooks/useTanakaAmazingCommodities.ts Changed import for WeightedChoice to weightedChoice.
src/services/PlaybackService.ts Renamed AdditionalPlaybackService to additionalPlaybackService.
src/utils/BiliFetch.ts Renamed BiliFetch to biliFetch; added timeout parameter and improved header management.
src/utils/Utils.ts Renamed WeightedChoice to weightedChoice.
src/utils/ffmpeg/ffmpeg.ts Enhanced error handling in base64AlbumArt function by logging errors instead of returning undefined.
src/utils/mediafetch/local.ts Updated cover property logic in songFetch; simplified resolveArtwork function.
src/utils/mediafetch/resolveURL.ts Changed return type of regexResolveArtworks from `Promise<string

Possibly related PRs

  • chore: dep upgrade #538: This PR also updates the package.json file, reflecting changes in dependency versions, including the expo package, which is relevant to the main PR's updates.
  • fix: last played duration #541: Modifications in src/hooks/useSetupPlayer.ts include updates to the player setup logic, which may relate to the overall functionality of the application as affected by dependency updates in the main PR.
  • feat: ytb live (streamed) #546: This PR updates the package.json file, including a version increment for the expo package, which aligns with the changes made in the main PR.
  • fix: noweeb style checks #563: The updates to package.json in this PR also include dependency version changes, which are relevant to the main PR's focus on updating dependencies.
  • feat: headless playback #566: Changes in this PR include modifications to the package.json file, particularly in dependencies, which are directly related to the updates made in the main PR.

🐇 In the garden where bunnies play,
New themes and updates brighten the day.
With tracks that flow and art that shines,
Our player hops through joyful designs!
So let’s cheer for each change, big and small,
For every little update, we celebrate all! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copy link

sentry-io bot commented Oct 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: The player is not initialized. Call setupPlayer first. buildBrowseTree(src/hooks/usePlaybackAA) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant