Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crossfade #594

Merged
merged 7 commits into from
Oct 24, 2024
Merged

feat: crossfade #594

merged 7 commits into from
Oct 24, 2024

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Oct 24, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced crossfade settings in developer options, allowing users to select crossfade durations for audio playback.
    • Enhanced player controls with a new method for skipping tracks and improved crossfade management.
    • Added new GIFs to the application theme for visual effects.
  • Bug Fixes

    • Refined logic for playback controls and error handling during track skipping.
  • Documentation

    • Updated localization files to include new entries for crossfade settings in both English and Chinese.
  • Chores

    • Updated various dependencies to improve performance and compatibility.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:06pm

@lovegaoshi lovegaoshi changed the title Dev feat: crossfade Oct 24, 2024
Copy link

coderabbitai bot commented Oct 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes significant updates across various files in the azusa-player-mobile project. Key changes involve upgrading multiple dependencies in package.json, enhancing player control functionality with new methods and state management in usePlayerControls and useTPControls, and introducing crossfade settings in the developer settings. Additionally, localization files have been updated to support new crossfade features, and new properties have been added to several interfaces and objects to accommodate these settings.

Changes

File Change Summary
package.json Updated dependencies and devDependencies, including versions for @sentry/react-native, i18next, and Babel packages.
src/components/player/controls/usePlayerControls.ts Added prepareSkipToNext method and enhanced crossfade state management, updated playback event handling.
src/components/setting/DeveloperSettings.tsx Introduced CrossFadeOptions constant and selectCrossFade method for crossfade duration settings in developer options.
src/components/styles/NoxTheme.ts Added two new GIF URLs to the gifs array.
src/hooks/useSetupPlayer.ts Modified initializePlayer to include parseEmbeddedArtwork and crossfade in serviceOptions.
src/hooks/useTPControls.ts Added prepareSkipToNext method and updated skip functions to utilize it.
src/localization/en/translation.json Added new keys for crossfade settings: crossfadeName, crossfadeDesc, and crossfadeTitle.
src/localization/zhcn/translation.json Added new keys for crossfade settings in Chinese localization.
src/objects/Storage.ts Added crossfade property to DefaultSetting initialized to 0.
src/services/SetupService.ts Updated SetupService to include crossfade parameter in the function signature.
src/stores/useApp.ts Added crossfadeId property and setCrossfadeId method to NoxSetting interface.
src/types/storage.d.ts Added crossfade property of type number to PlayerSettingDict interface.

Possibly related PRs

  • chore: dep upgrade #538: This PR involves updates to the package.json file, specifically upgrading the version of @sentry/react-native, which is also updated in the main PR.
  • fix: last played duration #541: This PR modifies the src/hooks/useSetupPlayer.ts file, which is also referenced in the main PR. Both PRs involve changes to the player setup process.
  • feat: no repeat #547: This PR includes changes to the src/components/player/controls/usePlayerControls.ts file, which is relevant as the main PR also discusses updates to player controls and functionality.
  • fix: noweeb style checks #563: This PR updates the package.json file with several dependency upgrades, including @sentry/react-native, which aligns with the updates in the main PR.
  • feat: 让我们说中文 #584: This PR adds support for the Chinese language in the application, which relates to the localization updates mentioned in the main PR.

🐰 In the code, I hop and play,
With crossfade magic, night and day.
Dependencies dance, all upgraded,
In developer settings, options cascaded.
So let the music flow and blend,
With each new change, our tunes transcend! 🎶


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lovegaoshi lovegaoshi merged commit e139fe8 into master Oct 24, 2024
4 checks passed
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant