feat: md3

[lovegaoshi]

and various other improvements
closes #615

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced a new Collapsible component for enhanced UI interactions.
  • Added dynamic styling for buttons and icons based on player settings.
  • Implemented improved service binding logic for better music service management.

• Bug Fixes

  • Enhanced error handling in various components to prevent crashes and improve stability.
  • Fixed issues with playlist rendering and song information display.

• Improvements

  • Updated color schemes throughout the application for a more cohesive look.
  • Refined logging and debugging practices to streamline performance.

• Chores

  • Cleaned up code by removing unnecessary console logs and optimizing imports.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
azusa-player-mobile	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 7:50pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request encompass various modifications across multiple files, primarily focusing on enhancing functionality and improving code clarity. Key updates include modifications to test cases for playlist functionality, enhancements to service binding logic in the Android widget, new interface implementations in the main activity, and the introduction of a collapsible component. Additionally, several UI components have been updated to utilize dynamic color properties based on application state, while various logging statements have been refined or removed to streamline debugging processes.

Changes

File Path	Change Summary
__tests__/mediafetch/ytbplaylist.test.ts	Updated test to use a playlist link and log the entire songList object.
android/app/src/main/java/com/noxplay/noxplayer/APMWidget.kt	Added bindOrStartService method for improved service binding; updated updateTrack and onReceive methods.
android/app/src/main/java/com/noxplay/noxplayer/MainActivity.kt	Introduced NoxActivity interface; modified onCreate to manage view drawing based on loadedRN state.
android/app/src/main/java/com/noxplay/noxplayer/NoxModule.kt	Added loadRN method for indicating React Native load status.
android/app/src/main/res/layout/a_p_m_widget.xml	Updated APMIcon attributes for accessibility and visual representation.
android/app/src/main/res/values/strings.xml	Added new string resource apmicon.
package.json	Updated various dependencies and added a new dependency @material/material-color-utilities.
src/components/bottomtab/NoxBottomTab.tsx	Added mode property to IconButton and updated background color logic.
src/components/buttons/AddPlaylistButton.tsx	Integrated useNoxSetting hook for dynamic iconColor.
src/components/commonui/Collapsible.tsx	Introduced Collapsible component for managing visibility and animations.
src/components/dialogs/GenericInputDialog.tsx	Removed selectionColor and textColor props from TextInput.
src/components/dialogs/NoxInput.tsx	Updated textColor prop for Input component.
src/components/explore/YTMusic.tsx	Modified transformation functions to improve property handling.
src/components/login/SiteSelector.tsx	Added collapsible functionality using useCollapsible and Collapsible component.
src/components/login/google/YTM.tsx	Refactored state management for authentication tokens and cookies.
src/components/login/useCollapsible.ts	Introduced Zustand store for managing collapsible state.
src/components/player/PlayerTopInfo.tsx	Added iconColor prop to IconButton components.
src/components/player/TrackInfo/ABSliderMenu.tsx	Updated color properties for ABSlider and label styles.
src/components/player/TrackInfo/TrackInfoTemplate.tsx	Changed text color properties for title and artist text.
src/components/player/controls/Progress.tsx	Updated ProgressBar color properties.
src/components/player/controls/ProgressBar.tsx	Modified Slider component color properties.
src/components/player/controls/usePlayerControls.ts	Enhanced playback event handling and logging.
src/components/playlist/Menu/PlaylistMenuButton.tsx	Integrated useNoxSetting for dynamic iconColor.
src/components/playlist/SongList/SongInfo.tsx	Updated background color and artist text color based on player style.
src/components/playlist/SongList/SongList.tsx	Introduced btnContainColor for button backgrounds.
src/components/playlists/Playlists.tsx	Updated playlist item rendering and color handling.
src/components/playlists/ShuffleAllButton.tsx	Integrated useNoxSetting for dynamic iconColor.
src/components/playlists/TimerButton.tsx	Integrated useNoxSetting for dynamic iconColor.
src/components/playlists/TimerDialog.tsx	Removed textColor prop from TextInput components.
src/components/playlists/View.tsx	Integrated playerStyle for dynamic icon colors.
src/components/setting/SplashSettings.tsx	Removed console logs for cleaner code.
src/components/setting/appearances/NoWeebDialog.tsx	Introduced new style for margin in NoxInput components.
src/components/setting/sync/PersonalSyncButton.tsx	Removed textColor prop from TextInput components.
src/components/setting/useRenderSetting.tsx	Updated color properties in SettingListItem and BooleanSetting components.
src/components/style.ts	Updated replaceStyleColor function for color validation and style handling.
src/components/styles/AzusaThemeRaw.ts	Modified color properties in theme configuration.
src/components/styles/NoxMD3ThemeConvert.js	Introduced MD3 theme color definitions and processing logic.
src/components/styles/NoxTheme.ts	Updated color values to hexadecimal format in theme configuration.
src/components/styles/NoxThemeGen.js	Added functionality for color conversion and theme generation.
src/components/styles/SteriaThemeDark.js	Updated color properties from RGB to hexadecimal format.
src/components/styles/steria.json	Comprehensive updates to multiple theme configurations and assets.
src/components/styles/steriaGarb.json	Updated color definitions across multiple themes.
src/hooks/useLyric.ts	Changed import source for reExtractSongName.
src/localization/en/translation.json	Standardized formatting of color-related labels.
src/objects/Song.ts	Changed import source for reExtractSongName.
src/services/PlaybackService.ts	Removed console logs for cleaner event handling.
src/stores/appStore.ts	Removed unused mappings and optimized state access.
src/stores/initializeStores.ts	Modified initialization logic and removed certain dependencies.
src/stores/regexStore.ts	Introduced Zustand store for regex-based song name extraction.
src/types/style.d.ts	Updated colors property type for enhanced type safety.
src/utils/BiliSubscribe.ts	Changed import source for parseSongName.
src/utils/LyricFetch.ts	Adjusted logging levels for error handling.
src/utils/RNTPUtils.ts	Enhanced audio playback and volume control functionality.
src/utils/mediafetch/ytbChannel.ts	Improved error handling and added console logs for video retrieval.
src/utils/mediafetch/ytbvideo.muse.ts	Removed debug logging in fetchAudioInfo function.
src/utils/mediafetch/ytbvideo.ytbi.ts	Enhanced error handling in suggest function and removed console logs.
src/utils/muse.ts	Introduced custom store implementation for managing state.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Service
    User->>App: Request to play song
    App->>Service: Fetch song data
    Service-->>App: Return song data
    App->>User: Play song

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Learn about MD3 theming (615)	✅

Possibly related PRs

• feat: ytbi playlist #543: Modifications to ytbplaylist.test.ts to check for a playlist link, directly related to the changes in this PR.
• fix: iOS ytbi #532: Changes to resolveURL in ytbvideo.ts, potentially affecting how playlists are fetched.
• feat: ytb live (streamed) #546: Introduces features related to YouTube live streaming, involving similar fetching mechanisms.
• feat: no repeat #547: Introduces a feature to prevent repeated playback, related to media functionality.
• fix: noweeb style checks #563: Addresses style checks related to color inputs, indicating a focus on UI consistency.

Poem

🐰
In the code where colors blend,
A playlist link we now commend.
Services bind and buttons glow,
With each update, our features grow!
So hop along, let’s test and play,
In our app, we’ll dance all day! 🎶

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud