DM-43736: Persist the PSF-matching kernel #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
force-pushed
the
tickets/DM-43736
branch
from
d11aec8
to
09e65a3
Compare
natelust
approved these changes
Apr 17, 2024
| doc="Kernel used to PSF match the science and template images.", | ||
| dimensions=("instrument", "visit", "detector"), | ||
| storageClass="MatchingKernel", | ||
| name="{fakesType}{coaddName}Diff_psfMatchKernel", |
There was a problem hiding this comment.
my only concern here, and it is a minor one, is that the name might be confusing seen in the registry or something. The dimensions of this type are visit, detector which are for the Exposure being matched, but the name refers to the coadd that is being matched to. This is not really a problem per-say, and I don't have an alternative solution, I just wanted to bring it to your attention in case you it sparked something in your mind.
There was a problem hiding this comment.
I think that's OK, since we already have several dataset types with the same dimensions and names such as {fakesType}{coaddName}Diff_templateExp so this should appear alongside many similarly-named registry entries.
isullivan
force-pushed
the
tickets/DM-43736
branch
from
09e65a3
to
94bd986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.