Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43736: Persist the PSF-matching kernel #310

Merged
merged 1 commit into from
Apr 17, 2024
Merged

DM-43736: Persist the PSF-matching kernel #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions python/lsst/ip/diffim/subtractImages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ class SubtractImageOutputConnections(lsst.pipe.base.PipelineTaskConnections,
storageClass="ExposureF",
name="{fakesType}{coaddName}Diff_matchedExp",
)
psfMatchingKernel = connectionTypes.Output(
doc="Kernel used to PSF match the science and template images.",
dimensions=("instrument", "visit", "detector"),
storageClass="MatchingKernel",
name="{fakesType}{coaddName}Diff_psfMatchKernel",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only concern here, and it is a minor one, is that the name might be confusing seen in the registry or something. The dimensions of this type are visit, detector which are for the Exposure being matched, but the name refers to the coadd that is being matched to. This is not really a problem per-say, and I don't have an alternative solution, I just wanted to bring it to your attention in case you it sparked something in your mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's OK, since we already have several dataset types with the same dimensions and names such as {fakesType}{coaddName}Diff_templateExp so this should appear alongside many similarly-named registry entries.

)


class SubtractScoreOutputConnections(lsst.pipe.base.PipelineTaskConnections,
Expand All @@ -106,6 +112,12 @@ class SubtractScoreOutputConnections(lsst.pipe.base.PipelineTaskConnections,
storageClass="ExposureF",
name="{fakesType}{coaddName}Diff_scoreExp",
)
psfMatchingKernel = connectionTypes.Output(
doc="Kernel used to PSF match the science and template images.",
dimensions=("instrument", "visit", "detector"),
storageClass="MatchingKernel",
name="{fakesType}{coaddName}Diff_psfScoreMatchKernel",
)


class AlardLuptonSubtractConnections(SubtractInputConnections, SubtractImageOutputConnections):
Expand Down
Loading