Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44150: Remove unnecessary DetectAndMeasure plugins #318

Merged
merged 5 commits into from
May 29, 2024
Merged

DM-44150: Remove unnecessary DetectAndMeasure plugins #318

merged 5 commits into from
May 29, 2024

Commits on May 29, 2024

  1. Remove GaussianFlux from diffim 

    We don't have a use for this flux measurement on diffim sources, which
are either dipoles, psfs, or trails, none of which are elliptical
Gaussians.
    @parejkoj
    parejkoj committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8401445 View commit details
    Browse the repository at this point in the history

  2. Switch to shapeHsm from SdssShape 

    shapeHsm handles negative sources better than SdssShape, otherwise
they're similar enough that there's no benefit here to running both.
    @parejkoj
    parejkoj committed May 29, 2024
    Configuration menu
    Copy the full SHA
    aa88941 View commit details
    Browse the repository at this point in the history

  3. Remove PeakLikelihoodFlux 

    This was carried over from much older code; we're now measuring on the
difference exposure instead of the score exposure, so we don't need it.
    @parejkoj
    parejkoj committed May 29, 2024
    Configuration menu
    Copy the full SHA
    b67a0df View commit details
    Browse the repository at this point in the history

  4. Revert "Switch to shapeHsm from SdssShape" 

    This reverts commit 2fd0aeb2e2bd2ca630956e4bbcb27829650e56d0.
    @parejkoj
    parejkoj committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c4ef1f6 View commit details
    Browse the repository at this point in the history

  5. Remove SdssShape from dipoleFit 

    DipoleFitTask doesn't use shape measurements, and SdssShape doesn't
handle negative sources well; detectAndMeasure uses shapeHsm, which is
better.
    @parejkoj
    parejkoj committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3b792af View commit details
    Browse the repository at this point in the history