Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44150: Remove unnecessary DetectAndMeasure plugins #318

Merged
merged 5 commits into from
May 29, 2024
Merged

DM-44150: Remove unnecessary DetectAndMeasure plugins #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8401445
Remove GaussianFlux from diffim
parejkoj May 20, 2024
aa88941
Switch to shapeHsm from SdssShape
parejkoj May 20, 2024
b67a0df
Remove PeakLikelihoodFlux
parejkoj May 20, 2024
c4ef1f6
Revert "Switch to shapeHsm from SdssShape"
parejkoj May 24, 2024
3b792af
Remove SdssShape from dipoleFit
parejkoj May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions python/lsst/ip/diffim/detectAndMeasure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ def setDefaults(self):
self.detection.thresholdType = "pixel_stdev"
self.detection.excludeMaskPlanes = ["EDGE", "SAT", "BAD", "INTRP"]

# Add filtered flux measurement, the correct measurement for pre-convolved images.
self.measurement.algorithms.names.add("base_PeakLikelihoodFlux")
self.measurement.plugins.names |= ["ext_trailedSources_Naive",
"base_LocalPhotoCalib",
"base_LocalWcs",
Expand Down
4 changes: 1 addition & 3 deletions python/lsst/ip/diffim/dipoleFitTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,14 @@ def setDefaults(self):
"base_PixelFlags",
"base_SkyCoord",
"base_PsfFlux",
"base_SdssShape",
"base_GaussianFlux",
]
# Only measure the apertures we need to report in the alert stream.
self.plugins["base_CircularApertureFlux"].radii = [12.0]

self.slots.calibFlux = None
self.slots.modelFlux = None
self.slots.gaussianFlux = None
self.slots.shape = "base_SdssShape"
self.slots.shape = None
# This will be switched to "ip_diffim_DipoleFit" as this task runs.
self.slots.centroid = "base_SdssCentroid"
self.doReplaceWithNoise = False
Expand Down
Loading