Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electric-truck icon #1803

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

LienMaas
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds an icon for electric trucks
image

Icon use case

Makes it possible to distinguish between regular and electric trucks.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: truck
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 14, 2024
Copy link

github-actions bot commented Jan 14, 2024

Added or changed icons

icons/truck-electric.svg

Preview cohesion icons/message-square-dashed.svg
icons/truck-electric.svg
icons/cog.svg
Preview stroke widths icons/truck-electric.svg
icons/truck-electric.svg
icons/truck-electric.svg
DPI Preview (24px) icons/truck-electric.svg
Icon X-rays icons/truck-electric.svg
Icon Diffs icons/truck-electric.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const TruckElectricIcon = createLucideIcon('TruckElectric', [
  ["path",{"d":"M14 18V6a2 2 0 0 0-2-2"}],
  ["path",{"d":"M15 18H9"}],
  ["path",{"d":"M19 18h2a1 1 0 0 0 1-1v-3.65a1 1 0 0 0-.22-.62L18.3 8.38a1 1 0 0 0-.78-.38H14"}],
  ["path",{"d":"M3 4.267A2 2 0 0 0 2 6v11a1 1 0 0 0 1 1h2"}],
  ["path",{"d":"M8.07 4 6.58 6.22A.5.5 0 0 0 7 7h2.13a.5.5 0 0 1 .42.78L8.07 10"}],
  ["circle",{"cx":"17","cy":"18","r":"2"}],
  ["circle",{"cx":"7","cy":"18","r":"2"}]
])

@ericfennis
Copy link
Member

@LienMaas Can we try to make a variant with the zap a bit bigger?
On 100% scale the zap looks a bit small.

@danielbayley
Copy link
Member

@LienMaas It should also be centred in the van I think. See also #1460, for consistency…

@LienMaas
Copy link
Author

@danielbayley I tried putting the zap in the middle, but the zap had to be really small to not violate the 2px rule.

This way I can definetly make the zap a bit bigger

@danielbayley
Copy link
Member

I tried putting the zap in the middle, but the zap had to be really small to not violate the 2px rule.
This way I can definetly make the zap a bit bigger

@LienMaas Yeah I meant something a bit like this…

preview

@ericfennis
Copy link
Member

Related to PR #1819, this could affect this icon's design.

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be using the new truck icon, see #1838

@github-actions github-actions bot added the Stale label Mar 7, 2024
Comment on lines 12 to 13
<path d="M12 6h1a1 1 0 0 1 1 1v11m0-9h4l4 4v4a1 1 0 0 1-1 1h-2m-4 0H9M3.2 6H3a1 1 0 0 0-1 1v10a1 1 0 0 0 1 1h2M8 6 6 9h4l-2 3" />
<path d="M17 20a2 2 0 1 0 0-4 2 2 0 0 0 0 4M7 20a2 2 0 1 0 0-4 2 2 0 0 0 0 4" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<path d="M12 6h1a1 1 0 0 1 1 1v11m0-9h4l4 4v4a1 1 0 0 1-1 1h-2m-4 0H9M3.2 6H3a1 1 0 0 0-1 1v10a1 1 0 0 0 1 1h2M8 6 6 9h4l-2 3" />
<path d="M17 20a2 2 0 1 0 0-4 2 2 0 0 0 0 4M7 20a2 2 0 1 0 0-4 2 2 0 0 0 0 4" />
<path d="M12 6h1a1 1 0 0 1 1 1v11" />
<path d="M14 9h3.172a2 2 0 0 1 1.414.586l2.828 2.828A2 2 0 0 1 22 13.828V17a1 1 0 0 1-1 1h-2" />
<path d="M15 18H9" />
<path d="M3.2 6H3a1 1 0 0 0-1 1v10a1 1 0 0 0 1 1h2" />
<path d="M8 6 6.518 8.223A.5.5 0 0 0 6.934 9h2.132a.5.5 0 0 1 .416.777L8 12" />
<circle cx="17" cy="18" r="2" />
<circle cx="7" cy="18" r="2" />

icon (55)

icons
Open lucide studio

icons/truck-electric.json Outdated Show resolved Hide resolved
icons/truck-electric.json Outdated Show resolved Hide resolved
@ericfennis
Copy link
Member

I think we should maybe go for the original design concept where the zap is in the corner. Because it is centered and with gap in the top it looks a bit if something is wrong with the truck. Like a crack 😄

@LienMaas
Copy link
Author

Something more like this than?

icons
Open lucide studio

@ericfennis
Copy link
Member

@LienMaas Looks more like it. But there should be 1px spacing with the canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants