Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ambulance icon #1819

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Add ambulance icon #1819

merged 6 commits into from
Jan 29, 2024

Conversation

jordan808
Copy link
Contributor

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds ambulance icon as requested by #119. Closes feather icons issue feathericons/feather#1177.

Icon use case

For navigation applications directing users to the nearest emergency services, or for listing an emergency contact.

Alternative icon designs

ambulance-alternative

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: Bus
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jan 20, 2024
Copy link

github-actions bot commented Jan 20, 2024

Added or changed icons

icons/ambulance.svg

Preview cohesion icons/pi-square.svg
icons/ambulance.svg
icons/list-todo.svg
Preview stroke widths icons/ambulance.svg
icons/ambulance.svg
icons/ambulance.svg
DPI Preview (24px) icons/ambulance.svg
Icon X-rays icons/ambulance.svg

icons/ambulance.svg Outdated Show resolved Hide resolved
Co-authored-by: Jakob Guddas <github@jguddas.de>
@jordan808 jordan808 changed the title Add ambulance icon Add ambulance icon Jan 20, 2024
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordan808 Nice icon, I like it!

For consistency, maybe an idea to update the truck design as well.
image

Maybe this is also a better shape to use in #1803

@jguddas
Copy link
Member

jguddas commented Jan 21, 2024

I feel like it's okay for the ambulance to be different and more boxy, that's also how they are in reality.

@ericfennis
Copy link
Member

@jguddas But I think the shape of the "truck" of @jordan808 fits way better with the lucide style, it's also vertically centered.

100% side by side:
Frame 139

@jguddas
Copy link
Member

jguddas commented Jan 21, 2024

@jguddas But I think the shape of the "truck" of @jordan808 fits way better with the lucide style, it's also vertically centered.

100% side by side:
Frame 139

Good point.

@jordan808
Copy link
Contributor Author

Below, I've explored some options to achieve greater consistency. The last one is my favorite, where the truck utilizes the same cab style as the ambulance icon in this PR. This choice would also be more modern, as the flat-face cab style (known as cab-overs or flat faces) has become less common in recent decades due to truck size regulations, at least in the U.S.

Here are some of my explorations aimed at enhancing consistency:

Cab heights same (taller):
ambulance-tall
truck-tall

Cab heights same (shorter):
ambulance-short
truck-short

Cab's styles same (taller):
ambulance-tall-matching
truck-tall-matching

Cab's styles same (shorter):
ambulance-short-matching
truck-short-matching

What do you all think @jguddas @ericfennis ?

@ericfennis
Copy link
Member

@jordan808 Nice work on the designs. It's hard to see differences. But I think I like the first and the third options. It uses the space on the canvas a bit better.

@jguddas
Copy link
Member

jguddas commented Jan 22, 2024

I like the first option the most.
image

@ericfennis ericfennis mentioned this pull request Jan 22, 2024
23 tasks
@jordan808
Copy link
Contributor Author

Do you all want to go with the first option then? If so, we would need to increase the cab height of the ambulance so that it is the same height as the truck if/when we update the truck icon. I'm warming up to the increased cab height anyway because it does utilize the verticle space better.

Proposed change to ambulance

ambulance-shortambulance-tall
Increase the cab height to reflect potential adjustment to truck icon.

Proposed change to truck

truck-originaltruck-tall
Increase trailer size, cab height, and round corners to 2px radius (Rule #7).

Finalized ambulance and truck comparison

ambulance-tall truck-tall

If you all approve, I can make the updated changes to the ambulance if needed.

@ericfennis
Copy link
Member

@jordan808 looks excellent 🤩. I'm in for the new truck icon.

icons/ambulance.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jordan808 jordan808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added contributors 👍

@ericfennis ericfennis merged commit cdd32b5 into lucide-icons:main Jan 29, 2024
7 checks passed
@jordan808 jordan808 deleted the icon/ambulance branch January 29, 2024 19:02
@ericfennis
Copy link
Member

@jordan808 Can you make a PR for the changes for the truck icon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants