Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate building play_routes to a helper to allow remote builds #39

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Separate building play_routes to a helper to allow remote builds #39

merged 2 commits into from
Jul 24, 2020

Conversation

vmax
Copy link
Contributor

@vmax vmax commented Jul 14, 2020

Fix #38
Two actions (executing routes compiler and then combining them with zipper) are collapsed into one, which allows for remote building

@SrodriguezO SrodriguezO requested a review from jjudd July 14, 2020 23:50
play-routes/play-routes-helper.sh Outdated Show resolved Hide resolved
Co-authored-by: David Neil <dvd.neil1@gmail.com>
@pauldraper
Copy link
Contributor

Is this because remote builds can't work with directories...?

Honestly, the whole zip/unzip stuff is really a pain. It would be nice if rules_scala and everything else supported directories.

@vmax
Copy link
Contributor Author

vmax commented Jul 15, 2020

@pauldraper yeah, the relevant issue (of not supporting directories in remote builds) is bazelbuild/bazel#6393

@pauldraper
Copy link
Contributor

@vmax I thought that issue was simply that declare_directory didn't create the directory for remote builds (unlike local builds).

And that tool could just create the dir themselves.

@SrodriguezO
Copy link
Contributor

@vmax have you verified that this change fixes the issue you observed in #38?

@vmax
Copy link
Contributor Author

vmax commented Jul 24, 2020

@SrodriguezO yes, we at @graknlabs are using our forked version extensively for ~2 weeks

@SrodriguezO
Copy link
Contributor

@vmax thanks for the update. We'll merge this :)

@SrodriguezO SrodriguezO merged commit 61bd14f into lucidsoftware:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to utilize play_routes rules in remote builds
4 participants