Colw/transaction service #3180
Colw/transaction service #3180
Conversation
VUE_APP_ENABLE_TX_API to enable tx service
Codecov Report
@@ Coverage Diff @@
## develop #3180 +/- ##
==========================================
+ Coverage 88.95% 90.7% +1.75%
==========================================
Files 126 126
Lines 1919 1958 +39
Branches 291 298 +7
==========================================
+ Hits 1707 1776 +69
+ Misses 205 177 -28
+ Partials 7 5 -2
|
| @@ -46,3 +61,167 @@ export const getMultiMessage = async (context, messages) => { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Bank | |||
| export function MsgSend( | |||
There was a problem hiding this comment.
Better export these functions from the library instead?
There was a problem hiding this comment.
Agreed, but they are not currently exported from the library. I can do this at a later time.
|
@colw maybe add some coverage to ActionManager? |
| this.gasEstimate = await this.actionManager.simulate(memo) | ||
| } else { | ||
| this.gasEstimate = await this.actionManager.simulateTxAPI( | ||
| this.createContext(), |
There was a problem hiding this comment.
The old functionality is still there, and you can opt-in to the transaction service by setting an environment variable when building the front end.
There was a problem hiding this comment.
he meant the context maybe. that is like a bunch of variables you need for the tx to be build
There was a problem hiding this comment.
yep, that's what i meant. but i don't see the function anywhere.
There was a problem hiding this comment.
It's around, line ~500. Not part of this PR though.
|
action modal is so large! |
What do you mean? Or rather, in which way? |
so many lines! |
Description:
Requires updated Lunie-API that fetches accountNum and sequence.Updated.Set
VUE_APP_ENABLE_TX_APItotrueto enable.Thank you! 🚀
For contributor:
yarn changelogfor a guided process.Files changedin the github PR explorerFor reviewer: