-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colw/transaction service #3180
Merged
Merged
Colw/transaction service #3180
Changes from 16 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
67221ce
Simple round trip
9222ada
Get gas estimate from transaction api
0f4d233
Modify gas estimate route to /transaction/estimate
d4cadb4
Remove console logs
6d284dc
Merge branch 'develop' into colw/transaction-service
6e06af3
Sign and broadcast messages
7eb642e
Lint
a4940ff
Enable TX service in config
f8546ff
Combine object
c054853
Add message type for broadcast.
851af2a
Support withdrawal
52d2475
Lint
072591b
changelog
d954630
Throw error on unsuccessful broadcast
86984ba
Remove logs, and capitalise error message
c415bf2
Merge branch 'develop' into colw/transaction-service
73bc34a
update lock file
faboweb 526eaac
WIP
9fd94a4
Lint
8d234db
Move function around
900e171
fixed missin import
faboweb b5f5ebc
mocked fetch
faboweb 4700e9a
Move request func to class
6448460
Update tests
03bb78c
Cover withdraw message type
8272b84
Use correct variable
b46b3c5
Test ignore all message types.
6a91a59
Ignore functions - will be imported from library
d09d9f5
Move ignore comment line to return statement
3fda07b
Missed one
dc67620
Ignore GraphQL
002f7fa
Merge branch 'develop' into colw/transaction-service
7f2506a
Test simulate tx service
6b30390
Set data
7636917
Use data variable for tx service flag
efb2f43
Removed unused method
a7f58ab
Ignore
95aecac
More ignore
da20247
Test send
938e51d
Fake test for throwing an error. TODO Remove not
8970d2a
Expect throw
64d0f64
Test tx failure
6f89092
Clean and test estimate failure
3aeb05d
Fix test
51c7b26
Test for messageconstructor
59d0697
Update variable name
06e8b5b
Test all networks
2c31435
Test status edge cases for page validator
4f1aeaa
Ignore watch and Apollo lines
e831877
Test transaction signer retrieval
379bcd3
Merge branch 'develop' into colw/transaction-service
6470d24
Lnt
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[Added] [#3180](https://github.com/cosmos/lunie/pull/3180) Use Lunie Transaction service to estimate an broadcast transactions @colw |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do @colw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old functionality is still there, and you can opt-in to the transaction service by setting an environment variable when building the front end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he meant the context maybe. that is like a bunch of variables you need for the tx to be build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that's what i meant. but i don't see the function anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's around, line ~500. Not part of this PR though.