Fabo/51 small fixes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbibla
reviewed
Nov 21, 2017
README.md
Outdated
| To debug the electron application first build it and then run the node inspector for the build files: | ||
|
|
||
| ```bash | ||
| $ electron --inspect-brk builds/{{you build}}/resources/app/dist/main.js |
jbibla
reviewed
Nov 21, 2017
README.md
Outdated
| Then attach to the debugger via the posted url in Chrome. | ||
|
|
||
|
|
||
| To debug the electron view, set the environment variable `COSMOS_DEVTOOLS` to sth. truthy like `"true"`. |
There was a problem hiding this comment.
maybe sth --> something (readme can be verbose)
mappum
previously approved these changes
Nov 21, 2017
| $ rm -rf app/yarn.lock | ||
| $ rm -rf app/package-lock.json | ||
| $ rm -rf yarn.lock | ||
| $ rm -rf package-lock.json |
There was a problem hiding this comment.
Funny and sad that we have to say to this... Maybe we should put it in a npm run rm-lockfiles script?
jbibla
approved these changes
Nov 22, 2017
faboweb
pushed a commit
that referenced
this pull request
Jun 2, 2020
…target Fabo/remove localhost as allowed target
faboweb
pushed a commit
that referenced
this pull request
Jun 2, 2020
* only sentry init code added * docker-compose changes * inspect removed
faboweb
added a commit
that referenced
this pull request
Jun 2, 2020
* added node install to docker * run npm install correct * don't copy modules * use env variables for testnet * Update pr.yml * github workflows changes * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Update pr.yml * Make search case-insensitive (#36) Modify variable names for clarity. * Query balance by denomination (#48) * colw/subscription-fix (#47) * Fix transaction destructure * Lint * Rename for consistency * Override method for V2 * Colw/fix denom and votes (#49) * Use larger denom for governance parameters * Lint * Fix: Leave in big number format for line #86 * Fabo/minor fixes (#51) * gracefully handle no rewards * always return balance * prevent error when no rewards * fix wrong delegation amount showing * log transaction if tag is empty (#58) * fix tally for running proposals (#54) * Fabo/move testnet definition into network configs file (#56) * move testnet definition into network configs file * use configs for endpoints * update cache key per block (#57) * colw/minor-fixes (#59) * Export testnet data for use in LunieDB Source * Fix get query * Mario/32 add proposal proposer (#52) * Add proposal proposer * Add proposer to proposals page * Revert package.js mod, use Promise.all * Call all queries at same time in getProposalById * Api error 500 fix * Fabo suggestions * Add cross-env * Resolve merge conflict * Fix merge error * deliver correct testnet url (#60) * Latest proposal should be on top (#61) * Colin's magic * const proposals * fix to not crash if no denom * Fabo/wait for stargate to be up (#62) * debug missing denom * do not call validators * await for the remote instance to be up before loading static data * remove logs * remove fallback * comment * Update cosmosV0-source.js * Update cosmosV0-source.js * Update cosmosV0-source.js * colw/subscription-refactor (#63) * Factor out subscription object * WIP * Reenable subs * Do not pre-populate cache (temp) This is run on every request. * Reenable static data * Fix * Remove comment * WIP * Use API class within subscription object * Update file and parameter naming * Load API classes once. * Revert "Load API classes once." ca567095360dbd7a8d81c7a53fe4fe885f3b63d2 * Set headers in separate method * format comment * Rename class variable * Split static data up * Adjust cache timing, default 5 * Update lib/schema.js Co-Authored-By: Fabian <frznhope@gmail.com> * Change client name to TendermintClient * Comment and rename for clarity * Cache specific blocks longer * Move Tendermint client to CosmosNodeSubscription * Comments for clarity * Clear memory after handling each new block (#66) * Fix typo and no return. (#68) * Aleksei/sentry added (#67) * only sentry init code added * docker-compose changes * inspect removed * colw/Decrease validator list loading time (#69) * Fetch validators each new block and store them * Store block, and sync validator map with block * Add block to store * Remove unused parameters * Retrieve a single validator form the map * Review fix: remove height parameter * Review fix: Change variable name for clarity * Return delegations and rewards from store (#70) * Return delegations and rewards from store * overview values * Remove unnecessary Promise.all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some fixes for the windows build.