Merge OpenFAST/dev + HD/SeaSt code cleanup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjonkman
commented
Aug 29, 2022
bjonkman
commented
- Merged OpenFAST/dev
- udpated some error handling (fixed potential memory leaks)
Allows to run the regression tests without running the simulations. This is useful for testing the regression test infrastructure itself. The option already existed in the reg test scripts, but it was not connected to CTest.
These test cases are too sensitive to be used reliably for software testing
The function to determine the passing channels was incorrectly using a global minimum instead of channel minimum to determine the absolutel tolerance.
- Copy input files needed for HydroDyn test cases (some files are stored in the glue-codes directory, so it will error if module is tested before glue-code is) - Return the completion code if a simulation did not run to the end (as opposed to comparing old results with no clear indication that the results are old) - fix missing variable in `executePythonRegressionCase.py` - if test_data and baseline_data are not the same size, return NaNs. We don't currently have a way to test if any of the columns are the same. - summary HTML file now contains columns for `Completion Code` and a link to the `.log` file containing screen output when the case ran (helpful for debugging) - fixed the issue where a blank line was printed to the screen for every line read in a ascii output file - fixed issue where specifying `-p` wouldn't generate plots but `-p=true` would (at least on my system) - make source directory an absolute path to fix issue when scripts to run module drivers change the working directory - add a `-module` optional argument to `manualRegressionTest.py` to allow it to execute the driver regression tests
Consolidate regression test baseline set
- Bokeh must be at least v2.4 - executeSeaStateRegressionCase.py has same changes as other module scripts that were changed in dev - manual test uses same keywords/arguments as execute*RegressionCase.py scripts
…t channels this still doesn't check that the outputs are in the same order, so we could be comparing different channels against each other....
…t channels this still doesn't check that the outputs are in the same order, so we could be comparing different channels against each other....
Test case OpenFAST#1217 included test case hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth, but the dev branch on r-test did not include this. In the previous commit, I mistakenly changed to OpenFAST/dev pointer to point to the r-test/dev which did not include the case. This effectively removed it. This commit along with the commit on r-test/dev puts this case back into the regression test suite.
This was causing issues with the M1 chipset on the MBPs
…-rtest r-test: Remove -m64 in CMAKE_Fortran_FLAG from r-test
Improvements to regression test python scripts
Seg Fault due to hub model and external inflow
attempt to make them consistent and able to be changed with a single variable
- cleanup up some error handling and potential memory leaks - fix issue where 4D data is ALWAYS copied to 3D
luwang00
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.