Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge OpenFAST/dev + HD/SeaSt code cleanup #5

Merged
merged 55 commits into from
Aug 30, 2022

Commits on Aug 1, 2022

  1. Clean up in rtestlib

    rafmudaf committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    84addf3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa66d5b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2b3d5c View commit details
    Browse the repository at this point in the history
  4. Unify baselines

    rafmudaf committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    22e8395 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    68ed80a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    acf2c89 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2d75a72 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c70fb2b View commit details
    Browse the repository at this point in the history
  9. Add a no-run flag to CTest options

    Allows to run the regression tests without running the simulations. This is useful for testing the regression test infrastructure itself. The option already existed in the reg test scripts, but it was not connected to CTest.
    rafmudaf committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    df1cc9e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    0b76b44 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7c2215b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    761ef68 View commit details
    Browse the repository at this point in the history
  13. Test ascii output silently

    rafmudaf committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    abcdb12 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    ccaabe4 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    8a59edd View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    d1daab1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    35387f7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ff1cf54 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Configuration menu
    Copy the full SHA
    0ffbe85 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Configuration menu
    Copy the full SHA
    0d8762b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Configuration menu
    Copy the full SHA
    e46cbaa View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Disable consistently inconsistent test cases

    These test cases are too sensitive to be used reliably for software testing
    rafmudaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    705bf08 View commit details
    Browse the repository at this point in the history
  2. Bug fix in finding the channel order of magnitude

    The function to determine the passing channels was incorrectly using a global minimum instead of channel minimum to determine the absolutel tolerance.
    rafmudaf committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    92ddaf3 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Improvements to regression-test python scripts

    - Copy input files needed for HydroDyn test cases (some files are stored in the glue-codes directory, so it will error if module is tested before glue-code is)
    - Return the completion code if a simulation did not run to the end (as opposed to comparing old results with no clear indication that the results are old)
    - fix missing variable in `executePythonRegressionCase.py`
    - if test_data and baseline_data are not the same size, return NaNs. We don't currently have a way to test if any of the columns are the same.
    - summary HTML file now contains columns for `Completion Code` and a link to the `.log` file containing screen output when the case ran (helpful for debugging)
    - fixed the issue where a blank line was printed to the screen for every line read in a ascii output file
    - fixed issue where specifying `-p` wouldn't generate plots but `-p=true` would (at least on my system)
    - make source directory an absolute path to fix issue when scripts to run module drivers change the working directory
    - add a `-module` optional argument to `manualRegressionTest.py` to allow it to execute the driver regression tests
    bjonkman committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    c045341 View commit details
    Browse the repository at this point in the history
  2. Add legend to error plots

    rafmudaf committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    134959c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    783925f View commit details
    Browse the repository at this point in the history
  4. Merge pull request OpenFAST#1217 from rafmudaf/q3/one_baseline

    Consolidate regression test baseline set
    rafmudaf authored Aug 18, 2022
    Configuration menu
    Copy the full SHA
    2ea9bcb View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. Configuration menu
    Copy the full SHA
    1910374 View commit details
    Browse the repository at this point in the history
  2. Fix broken manual regression test

    - Bokeh must be at least v2.4
    - executeSeaStateRegressionCase.py has same changes as other module scripts that were changed in dev
    - manual test uses same keywords/arguments as execute*RegressionCase.py scripts
    bjonkman committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c8b2477 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    edea770 View commit details
    Browse the repository at this point in the history
  2. python scripts: avoid plotting errors with different numbers of outpu…

    …t channels
    
    this still doesn't check that the outputs are in the same order, so we could be comparing different channels against each other....
    bjonkman committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    be4c884 View commit details
    Browse the repository at this point in the history
  3. update r-test

    bjonkman committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    6eb4920 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4fc9d81 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cec8dfa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6adf4ac View commit details
    Browse the repository at this point in the history
  7. python scripts: avoid plotting errors with different numbers of outpu…

    …t channels
    
    this still doesn't check that the outputs are in the same order, so we could be comparing different channels against each other....
    bjonkman committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b22fc02 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cd14fab View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4923e05 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    93b5288 View commit details
    Browse the repository at this point in the history
  11. r-test: missing test case after merge of OpenFAST#1217

    Test case OpenFAST#1217 included test case hd_5MW_OC4Jckt_DLL_WTurb_WavesIrr_MGrowth, but the dev branch on r-test did not include this.  In the previous commit, I mistakenly changed to OpenFAST/dev pointer to point to the r-test/dev which did not include the case.  This effectively removed it.  This commit along with the commit on r-test/dev puts this case back into the regression test suite.
    andrew-platt committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    fccee33 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    273e9c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. r-test: Remove -m64 in CMAKE_Fortran_FLAG from r-test

    This was causing issues with the M1 chipset on the MBPs
    andrew-platt committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a8b7c89 View commit details
    Browse the repository at this point in the history
  2. Merge pull request OpenFAST#1228 from andrew-platt/b/CMake_FlagUpdate…

    …-rtest
    
    r-test: Remove -m64 in CMAKE_Fortran_FLAG from r-test
    andrew-platt authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0a6d2f0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request OpenFAST#1222 from bjonkman/f/Python_RegTests

    Improvements to regression test python scripts
    andrew-platt authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    19b4ca7 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. [bugfix] Seg Fault due to hub model and external inflow (OpenFAST#1227)

    Seg Fault due to hub model and external inflow
    psakievich authored Aug 25, 2022
    Configuration menu
    Copy the full SHA
    b888e4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de3a9c2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7ae3388 View commit details
    Browse the repository at this point in the history
  4. Cleanup size of lines read from file

    attempt to make them consistent and able to be changed with a single variable
    bjonkman committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5b0823a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4708737 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Configuration menu
    Copy the full SHA
    0076b03 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dd123af View commit details
    Browse the repository at this point in the history
  3. HD/SeaSt: update error handling + code cleanup

    - cleanup up some error handling and potential memory leaks
    - fix issue where 4D data is ALWAYS copied to 3D
    bjonkman committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    d7b57ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f088391 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4dae42a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. update r-test

    bjonkman committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    43cc15b View commit details
    Browse the repository at this point in the history