Merge OpenFAST dev + other SeaState/HydroDyn code cleanup #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs: update manual regression testing syntax for Windows
Sometimes a segmentation fault was occuring due to the flag for WAT not getting initialized (feature that is in process)
This fixes an issue in the UnsteadyAero regression test
Remove QuKi (quad-precision) from OpenFAST.
Also add input file updates
- remove checks on changing DT after calling WAMIT and WAMIT2 (since it can't change there anyway) - removed WAMIT InitOut type since it was empty - Conv_Rdtm_Init no longer sets Interval, but it was set to that same value before calling WAMIT
This commit undoes most of the changes in PR OpenFAST#1010 which introduced object libraries into the build system to produce a statically linked MEX file for Simulink. The Object Libraries were somewhat complex and didn't behave the same as normal libraries. While trying to debug a compilation issue on an M1 mac the CMake `matlab_add_mex` function was discovered which could build a static mex file within CMake. The build system was reworked to use this feature.
There was some duplication in processing of OpenMP flags between FAST.Farm and openfastcpp which caused compile issues. Finding the package and adding flags were moved to the main CMakeLists.txt. This also sets the LINKER_LANGUAGE to Fortran for openfastlib and fixes a typo in the VersionInfo CMake file.
Also set number of parallel builds using CMAKE_BUILD_PARALLEL_LEVEL environment variable instead of specifying -j. Total action run time reduced by 10-15 minutes
- it is used so many times.... This routine should be split into smaller routines.
WAMIT/Conv_Rdtn
…InputsFile match NSteps in the HD driver input
Bug Fix: HD driver not reading the PRP motion input file correctly and missing variable declaration in the MD driver
[BugFix] Modernize CMake, remove object libraries, build Simulink MEX
also remove unused variable in MD driver
Updates to Allow Non-Uniform Force Point Distribution on Blades
The Requests package from python is incompatible with urllib3. See psf/requests#6432 for issue others have run into.
…SION` This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
[BugFix] Limit urllib3 version for readthedocs building
…SION` This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
This backward-compatibility of preprocessor definitions from OpenFAST#524 was broken in OpenFAST#1453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have documented the differences in the regression tests, run on my local PC: SeaStateBranch_RegTestFailures.pdf GH actions fails at various points in the test (some seem to be random AeroDyn problems), so it never gets a complete set of HD tests.
Feel free to modify r-tests as needed--especially if I don't have the equivalent input files set up properly. I probably won't have time to work on this for quite a while.
@andrew-platt, this is ready for you to update the HydroDyn python/C-bindings.