Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance stereo depth #178

Closed
wants to merge 28 commits into from
Closed

Enhance stereo depth #178

wants to merge 28 commits into from

Conversation

alex-luxonis
Copy link
Collaborator

Add options to configure:

  • the kernel size of the median filter that is applied over the disparity map: 3x3, 5x5, 7x7 (default), or disabled.
  • enabling the Left-Right check feature (runs disparity on both directions and combines them).
  -med {0,3,5,7}, --stereo_median_size {0,3,5,7}
                        Disparity / depth median filter kernel size (N x N) .
                        0 = filtering disabled. Default: 7
  -lrc, --stereo_lr_check
                        Enable stereo 'Left-Right check' feature.

Currently, the disparity map works well (disparity, disparity_color streams), but there is a problem with depth_raw and the -lrc option (WIP).
(It's also better to use a disparity stream to visualize the map quality).

Currently, with -lrc, the median filtering (if not disabled) is applied on each direction (L-R and R-L), before combining. We may need to move it after the combine step.

Example usage: ./depthai.py -s disparity_color -med 5 -lrc

@alex-luxonis
Copy link
Collaborator Author

Merged in the branch metadata_disparity_depth, with these changes:

  • added frame metadata for disparity, disparity_color, depth_raw streams too. Previously it was present only for previewout, left, right, metaout (NN packets).
  • fixed streaming out depth_raw with the full resolution 1280×800 (-monor 800 option)

@VanDavv
Copy link
Contributor

VanDavv commented Aug 27, 2020

@alex-luxonis can we close this PR? I tried to also check metadata_disparity_depth but there seems to be no -lrc or med flags.

Currently, this branch produces a flickering result
ezgif com-video-to-gif (1)

@alex-luxonis
Copy link
Collaborator Author

Will rebase the work here on develop, then close it. The flicker should only happen with -lrc which is a new option (and I'll fix it).
About the metadata_disparity_depth branch, that one was merged into this. So now metadata_disparity_depth is obsolete.

@Luxonis-Brandon
Copy link
Contributor

I think we can close this now. So closing now but we can always reopen.

@SzabolcsGergely SzabolcsGergely deleted the enhance_stereo_depth branch September 26, 2020 02:13
jdavidberger pushed a commit to constructiverealities/depthai that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants