-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance stereo depth develop merge #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use a mesh instead of homography - disable mirroring the rectified frame (mirroring is normally a requirement for the Stereo Engine) - set the color of the pixels at the Warp edges (may ease debugging)
changed l-r dist to 4cm, and l-rgb dist to 1cm
changed file name to call caps to match other files
Create bw1092.json to allow calibration and eeprom settings
…vice side. Also move the inversion step before fp32 conversion (just in case).
Updated USB3 FW and Linux64 lib
- allow running rectified_left/_right streams without disparity/depth
jonngai
reviewed
Sep 11, 2020
jonngai
reviewed
Sep 11, 2020
This was referenced Sep 11, 2020
Closed
(to easily distinguish in future from a valid calib)
Note: currently when mirroring is disabled, rectified_left/_right are swapped.
saching13
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Tested. depth_raw, disparity, pcl on different resolution. mirror_frame too along with default AI model. on both version 4 and 5 of eeprom.
SzabolcsGergely
added a commit
that referenced
this pull request
Oct 30, 2020
Enhance stereo depth develop merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #178 merged into develop.
Run:
python3 -m pip install -r requirements.txt