Polish contribution

See spring-projectsgh-26462 Closes spring-projectsgh-26586
lxbzmy · Mar 26, 2022 · 1e34107 · 1e34107
1 parent ba18d62
commit 1e34107
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/spring-core/src/main/java/org/springframework/core/env/StandardEnvironment.java b/spring-core/src/main/java/org/springframework/core/env/StandardEnvironment.java
@@ -60,9 +60,17 @@ public class StandardEnvironment extends AbstractEnvironment {
 	public static final String SYSTEM_PROPERTIES_PROPERTY_SOURCE_NAME = "systemProperties";
 
 
+	/**
+	 * Create a new {@code StandardEnvironment} instance.
+	 */
 	public StandardEnvironment() {
 	}
 
+	/**
+	 * Create a new {@code StandardEnvironment} instance with a specific {@link MutablePropertySources} instance.
+	 * @param propertySources property sources to use
+	 * @since 5.3.4
+	 */
 	protected StandardEnvironment(MutablePropertySources propertySources) {
 		super(propertySources);
 	}

diff --git a/spring-core/src/test/java/org/springframework/core/env/CustomEnvironmentTests.java b/spring-core/src/test/java/org/springframework/core/env/CustomEnvironmentTests.java
@@ -108,7 +108,7 @@ protected Set<String> getReservedDefaultProfiles() {
 	}
 
 	@Test
-	public void withNoProfileProperties() {
+	void withNoProfileProperties() {
 		ConfigurableEnvironment env = new AbstractEnvironment() {
 			@Override
 			@Nullable
@@ -131,7 +131,7 @@ protected String doGetDefaultProfilesProperty() {
 	}
 
 	@Test
-	public void withCustomMutablePropertySources() {
+	void withCustomMutablePropertySources() {
 		class CustomMutablePropertySources extends MutablePropertySources {}
 		MutablePropertySources propertySources = new CustomMutablePropertySources();
 		ConfigurableEnvironment env = new AbstractEnvironment(propertySources) {};

diff --git a/...web/src/main/java/org/springframework/web/context/support/StandardServletEnvironment.java b/...web/src/main/java/org/springframework/web/context/support/StandardServletEnvironment.java
@@ -54,9 +54,17 @@ public class StandardServletEnvironment extends StandardEnvironment implements C
 	public static final String JNDI_PROPERTY_SOURCE_NAME = "jndiProperties";
 
 
+	/**
+	 * Create a new {@code StandardServletEnvironment} instance.
+	 */
 	public StandardServletEnvironment() {
 	}
 
+	/**
+	 * Create a new {@code StandardServletEnvironment} instance with a specific {@link MutablePropertySources} instance.
+	 * @param propertySources property sources to use
+	 * @since 5.3.4
+	 */
 	protected StandardServletEnvironment(MutablePropertySources propertySources) {
 		super(propertySources);
 	}