Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AbstractEnvironment subclasses to use custom ConfigurablePropertyResolver and MutablePropertySources #26462

Closed
philwebb opened this issue Jan 27, 2021 · 1 comment
Closed

Allow AbstractEnvironment subclasses to use custom ConfigurablePropertyResolver and MutablePropertySources #26462

philwebb opened this issue Jan 27, 2021 · 1 comment
Assignees
@snicoll @jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.3.4

Comments

@philwebb
Copy link
Member

Currently AbstractEnvironment directly creates a MutablePropertySources and PropertySourcesPropertyResolver. It would be helpful to use factory methods so that subclasses can use different implementations.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 27, 2021
@philwebb
Copy link
Member Author

I pushed a suggested implementation here

@jhoeller jhoeller self-assigned this Jan 28, 2021
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 28, 2021
@jhoeller jhoeller added this to the 5.3.4 milestone Jan 28, 2021
@wilkinsona wilkinsona mentioned this issue Feb 2, 2021
Closed
philwebb added a commit to philwebb/spring-framework that referenced this issue Feb 3, 2021
@philwebb
Allow customer resolver and property sources
305e38b 
Add factory methods to `AbstractEnvironment` that allow a custom
`ConfigurablePropertyResolver` and `MutablePropertySources` instance
to be used.

Closes spring-projectsgh-26462
snicoll pushed a commit that referenced this issue Feb 15, 2021
@philwebb @snicoll
Allow customer resolver and property sources
d4c609f 
Add factory methods to `AbstractEnvironment` that allow a custom
`ConfigurablePropertyResolver` and `MutablePropertySources` instance
to be used.

See gh-26462
snicoll added a commit that referenced this issue Feb 15, 2021
@snicoll
Polish "Allow customer resolver and property sources"
582559d 
See gh-26462
jhoeller added a commit that referenced this issue Feb 16, 2021
@jhoeller
Nullability refinements
9417975 
See gh-26462
@sync-by-unito sync-by-unito bot mentioned this issue Feb 17, 2021
Merged
sbrannen pushed a commit that referenced this issue Feb 22, 2021
@izeye
Polish contribution
dfc8406 
See gh-26462
Closes gh-26586
This was referenced Mar 7, 2021
Open
Closed
Closed
Open
Open
Closed
Open
Open
Merged
Open
Open
Open
Closed
This was referenced Mar 13, 2021
Merged
Merged
Closed
Open
Open
Merged
Open
Open
Merged
Open
Open
Merged
Open
Open
Open
Open
Open
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@philwebb @lxbzmy
Allow customer resolver and property sources
3215382 
Add factory methods to `AbstractEnvironment` that allow a custom
`ConfigurablePropertyResolver` and `MutablePropertySources` instance
to be used.

See spring-projectsgh-26462
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@snicoll @lxbzmy
Polish "Allow customer resolver and property sources"
b5bc7f7 
See spring-projectsgh-26462
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@jhoeller @lxbzmy
Nullability refinements
d849de1 
See spring-projectsgh-26462
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@izeye @lxbzmy
Polish contribution
1e34107 
See spring-projectsgh-26462
Closes spring-projectsgh-26586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.4
Development

No branches or pull requests
4 participants
@snicoll @philwebb @jhoeller @spring-projects-issues