Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is Devise option Rememberable required ? #80

Closed
nicolas-besnard opened this issue Nov 30, 2014 · 2 comments
Closed

Is Devise option Rememberable required ? #80

nicolas-besnard opened this issue Nov 30, 2014 · 2 comments

Comments

@nicolas-besnard
Copy link
Contributor

According to the documentation about Rememberable options, this option deals with cookies. Since I don't require cookie in my API project, I think this option can be remove. What do you think ?

According to #78, what do you think about authorize user of this gem to customize Devise options ?
@nicolas-besnard nicolas-besnard changed the title Is Devise options Rememberable required ? Is Devise option Rememberable required ? Nov 30, 2014
@lynndylanhurley
Copy link
Owner

You might be right about this. I'll look into it ASAP.

@jartek jartek mentioned this issue Dec 14, 2014
Merged
lynndylanhurley added a commit that referenced this issue Dec 22, 2014
@lynndylanhurley
Merge branch 'jartek-exclude_devise_modules'.
46e3ac7 
Fixes #78 #80 #60.
@lynndylanhurley
Copy link
Owner

I just removed :rememberable and all the tests still pass. Looks like you were right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lynndylanhurley @nicolas-besnard