-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude devise modules #85
Exclude devise modules #85
Conversation
@jartek - thank you so much for this PR! This is by far the most requested feature. My only concern with this PR is that this seems to set the included modules globally, but they should be configurable on a per-model basis. Consider this use-case:
Can you revise this PR to address that use-case? |
👍 Will do. |
@lynndylanhurley wouldn't it be better if the code for choosing devise modules was moved out of the concern and into each class that requires concern? Can't think of a simpler way to do this right now other than specifying it via global options |
@jartek - I think that's the only way to go about this. |
bef2875
to
2d398d0
Compare
@lynndylanhurley I've updated the PR. |
Awesome, thanks @jartek! I'll review ASAP! |
I did the same think as you do, but I don't think to do a PR :( I'll look at it tomorrow morning, great job ! |
I just try hit, sounds good to me :) |
Ok guys, I released these fixes. Check out version 0.1.31.beta1 and let me know if everything works as expected. Documentation is here. |
thanks 👍 |
Just what I needed! Thank you @lynndylanhurley. |
Add a configuration option to exclude devise modules from the defaults.
Fixes #78 #80 #60
@lynndylanhurley thoughts?