-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CrAzYpass implementation #234
Conversation
@erciccione @hrumag @Lafudoci @anhdres I have added the new/changed english texts to the the 'es', 'it' and 'zh-TW' translations.
Please note, that in help.xml, texts need Maybe you want to add something to the Thank you all very much! |
f41f4a8
to
6cdeaba
Compare
Got it, I updated the instructions on Taiga: https://taiga.getmonero.org/project/erciccione-monero-localization/wiki/monerujo |
@m2049r I'm working on it. I'll make PR when it's done. And I am wondering should I put all the contributors during translation (including reviewers) in credits_text? Or just commit contributors? |
the credits overlay is very small and should stay that way - but it should probably link to a full list of contributors. either in the app or maybe github or the website. |
So should I put me and another commit contributor who translated policy in credits_text ? Or better leave it for code developers and wait for the full list page/link? |
Based on this post & paper:
In addition. we have decided to make the CrAzYpass a string of uppercase alphanumerics
[2-9A-HJ-NP-Z]
(i.e. no 0,1,O,I) with spaces after every four characters. Thus the 256-bit key is encoded base 32. There are always 13 groups of 4 characters (padded with2
's if necessary).