Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrAzYpass implementation #234

Merged
merged 1 commit into from
Apr 21, 2018
Merged

CrAzYpass implementation #234

merged 1 commit into from
Apr 21, 2018

Conversation

m2049r
Copy link
Owner

@m2049r m2049r commented Apr 20, 2018

Based on this post & paper:

In addition. we have decided to make the CrAzYpass a string of uppercase alphanumerics [2-9A-HJ-NP-Z] (i.e. no 0,1,O,I) with spaces after every four characters. Thus the 256-bit key is encoded base 32. There are always 13 groups of 4 characters (padded with 2's if necessary).

@m2049r
Copy link
Owner Author

m2049r commented Apr 20, 2018

@erciccione @hrumag @Lafudoci @anhdres

I have added the new/changed english texts to the the 'es', 'it' and 'zh-TW' translations.
Only two files are affected.

  • strings.xml: the english text is enclosed in [ and ] so you can easily find the strings in need of translating by searching for ]</string>

  • help.xml: one section ("Wallet Files Recovery Password") is added in the help_details section.

Please note, that in help.xml, texts need ' to be written as &apos; and " as \".

Maybe you want to add something to the credits_text in about.xml.

Thank you all very much!

@erciccione
Copy link
Contributor

Got it, I updated the instructions on Taiga: https://taiga.getmonero.org/project/erciccione-monero-localization/wiki/monerujo

@m2049r m2049r merged commit 073bd96 into master Apr 21, 2018
@Lafudoci
Copy link
Contributor

@m2049r I'm working on it. I'll make PR when it's done. And I am wondering should I put all the contributors during translation (including reviewers) in credits_text? Or just commit contributors?

@m2049r
Copy link
Owner Author

m2049r commented Apr 21, 2018

the credits overlay is very small and should stay that way - but it should probably link to a full list of contributors. either in the app or maybe github or the website.

@Lafudoci
Copy link
Contributor

So should I put me and another commit contributor who translated policy in credits_text ? Or better leave it for code developers and wait for the full list page/link?

@m2049r m2049r deleted the feature_crazypass branch April 22, 2018 09:28
el00ruobuob added a commit to el00ruobuob/xmrwallet that referenced this pull request Apr 22, 2018
el00ruobuob added a commit to el00ruobuob/xmrwallet that referenced this pull request Apr 23, 2018
el00ruobuob added a commit to el00ruobuob/xmrwallet that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants