Avoid duplicate ident.ID conversions (#935)

* Avoid duplicate ident.ID conversions
m3db · Sep 25, 2018 · ed1dc9f · ed1dc9f
1 parent eef049a
commit ed1dc9f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/query/storage/m3/storage.go b/src/query/storage/m3/storage.go
@@ -255,11 +255,13 @@ func (s *m3storage) Write(
 	}
 
 	id := query.Tags.ID()
+	// TODO: Consider caching id -> identID
+	identID := ident.StringID(id)
 	common := &writeRequestCommon{
 		store:       s,
 		annotation:  query.Annotation,
 		unit:        query.Unit,
-		id:          id,
+		id:          identID,
 		tagIterator: storage.TagsToIdentTagIterator(query.Tags),
 		attributes:  query.Attributes,
 	}
@@ -282,7 +284,7 @@ func (s *m3storage) Close() error {
 func (w *writeRequest) Process(ctx context.Context) error {
 	common := w.writeRequestCommon
 	store := common.store
-	id := ident.StringID(common.id)
+	id := common.id
 
 	var (
 		namespace ClusterNamespace
@@ -321,7 +323,7 @@ type writeRequestCommon struct {
 	store       *m3storage
 	annotation  []byte
 	unit        xtime.Unit
-	id          string
+	id          ident.ID
 	tagIterator ident.TagIterator
 	attributes  storage.Attributes
 }