Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate ident.ID conversions #935

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Avoid duplicate ident.ID conversions #935

merged 2 commits into from
Sep 25, 2018

Conversation

nikunjgit
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #935 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   77.98%   77.95%   -0.04%     
==========================================
  Files         411      411              
  Lines       34407    34408       +1     
==========================================
- Hits        26834    26824      -10     
- Misses       5730     5741      +11     
  Partials     1843     1843
Flag Coverage Δ
#dbnode 81.51% <ø> (-0.06%) ⬇️
#m3ninx 75.3% <ø> (+0.07%) ⬆️
#query 64.3% <100%> (ø) ⬆️
#x 84.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe161b...f523614. Read the comment docs.

@nikunjgit nikunjgit merged commit ed1dc9f into master Sep 25, 2018
@nikunjgit nikunjgit deleted the nikunj/identfix branch September 25, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants