[coordinator] Fix Graphite metric ID formatting using m3aggregator with m3coordinator #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or and m3coordinator for downsampling
arnikola
reviewed
Dec 6, 2019
| // and this tag is interpreted, eventually need to handle more cleanly. | ||
| if bytes.Equal(name, downsample.MetricsOptionIDSchemeTagName) { | ||
| if bytes.Equal(value, downsample.GraphiteIDSchemeTagValue) && | ||
| op.q.Tags.Opts.IDSchemeType() != models.TypeGraphite { |
There was a problem hiding this comment.
Oof yuck :p
small nit: probably be slightly more performant to check for scheme type first? Or to get that as a bool earlier to avoid function calls?
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
========================================
Coverage ? 72.2%
========================================
Files ? 1014
Lines ? 87372
Branches ? 0
========================================
Hits ? 63107
Misses ? 20013
Partials ? 4252
Continue to review full report at Codecov.
|
arnikola
approved these changes
Jan 3, 2020
| @@ -140,6 +140,10 @@ func (w *downsamplerFlushHandlerWriter) Write( | |||
|
|
|||
| // NB(r): Quite gross, need to actually make it possible to plumb this | |||
| // through for each metric. | |||
| // TODO_FIX_GRAPHITE_TAGGING: Using this string constant to track | |||
There was a problem hiding this comment.
Definitely will be here... for a while..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes Graphite metric ID formatting using m3aggregator with m3coordinator for downsampling (instead of embedded downsampling).
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: