etcd_docker 6: Remove etcd embed from M3DB node (#4150) #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* etcd_docker 5: Incorporate docker based etcd approach into docker integration tests. PR 5 for #4144 This PR makes the docker integration tests use containerized etcd. Previously, these relied on M3DB running an embbeded etcd server. There's no inherent need for this, and it opens us up to dependency issues as described in the linked github issue. Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those back at a later date.. commit-id:e67a5172 * etcd_docker 6: Remove etcd embed from M3DB node PR 6 for #4144 Now that all test usages of the embed package had been removed, this PR removes the usage of the embed package from the m3db server itself. N.B.: this PR currently makes no attempt to fix up any "quick start" flows relying on embedded etcd; that will come later. commit-id:2870a75c
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/2870a75c
branch
from
dfae59c
to
f2e9ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 5 for #4144
This PR makes the docker integration tests use containerized etcd.
Previously, these relied on M3DB running an embbeded etcd server.
There's no inherent need for this, and it opens us up to dependency issues as described
in the linked github issue.
Note: there are a handful that require multiple servers; these are currently "skipped" (commented). I intend to bring those
back at a later date..
Stack: