Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd_docker 2: Add a docker based etcdintegration package #4154

Conversation

andrewmains12
Copy link
Contributor

@andrewmains12 andrewmains12 commented Sep 9, 2022

PR 2 for #4144

High level approach is as described in #4144 . This PR adds:

  • Functions to spin up a 1 node etcd cluster using docker (in dockerexternal)
  • A drop in replacement for the etcd/integration package using dockerexternal

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa branch from 747a40f to d3246b4 Compare March 24, 2023 15:52
Base automatically changed from pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa to master March 24, 2023 16:10
PR 2 for #4144

High level approach is as described in #4144 . This PR adds:

- Functions to spin up a 1 node etcd cluster using docker (in `dockerexternal`)
- A drop in replacement for the etcd/integration package using `dockerexternal`

commit-id:7aeae843
@andrewmains12 andrewmains12 force-pushed the pr/andrewmains12/amains/grpc-update/etcd_tests.review/7aeae843 branch from c674683 to b607f4c Compare March 24, 2023 16:36
@andrewmains12 andrewmains12 merged commit fbd938b into master Mar 24, 2023
@andrewmains12 andrewmains12 deleted the pr/andrewmains12/amains/grpc-update/etcd_tests.review/7aeae843 branch March 24, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants