etcd_docker 3: Incorporate docker based etcd integration package into… #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
4640094
to
780280f
Compare
This was referenced Mar 14, 2023
justinjc
approved these changes
Mar 22, 2023
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
780280f
to
fa338b9
Compare
Base automatically changed from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/7aeae843
to
master
March 24, 2023 17:13
#4147) PR 3 for #4144 High level approach is as described in #4144 . This PR incorporates the new test package into our unittests. Usage is via the `etcdintegration` package, which makes it transparent to the test code; it simply gets an etcd server started via different means. One piece of weirdness to call out here: the package currently relies on autosync being *disabled* on the client side. This is because the advertise client URL (aka what etcd tells clients to connect to) isn't correct for the open port on the host. That is we have: - etcd: listen on container port 0.0.0.0:2379, advertise 0.0.0.0:2379 - docker: expose etcd port 2379 to 0.0.0.0:0 on host machine (random free port) - client: connect to etcd via host machine. We could probably make this better. commit-id:263fed13
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
fa338b9
to
8d896f4
Compare
andrewmains12
changed the title
andrewmains12
deleted the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…… (#4147)
PR 3 for #4144
High level approach is as described in #4144 .
This PR incorporates the new test package into our unittests. Usage is via the
etcdintegrationpackage, whichmakes it transparent to the test code; it simply gets an etcd server started via different means.
One piece of weirdness to call out here: the package currently relies on autosync being disabled on the client side.
This is because the advertise client URL (aka what etcd tells clients to connect to) isn't correct for the open port on the host.
That is we have:
We could probably make this better.
commit-id:263fed13
Stack: