Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Create constant for annotation value indicating enabled #239

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

jeromefroe
Copy link
Collaborator

This commit defines the string that we look for to indicate that an annotation has been enabled ("enabled") as a constant so it can be imported by other packages.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #239 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   76.08%   76.21%   +0.13%     
==========================================
  Files          30       30              
  Lines        2170     2161       -9     
==========================================
- Hits         1651     1647       -4     
+ Misses        385      381       -4     
+ Partials      134      133       -1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d59f5f...7e5edb7. Read the comment docs.

Copy link
Collaborator

@wybczu wybczu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromefroe jeromefroe merged commit b242e67 into master Sep 30, 2020
@jeromefroe jeromefroe deleted the jerome/controller/use-constant-for-enabled branch September 30, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants