Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Create constant for annotation value indicating enabled #239

Merged
merged 1 commit into from
Sep 30, 2020
Merged

[controller] Create constant for annotation value indicating enabled #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ func updatedStatefulSet(
) (*appsv1.StatefulSet, bool, error) {
// The operator will only perform an update if the current StatefulSet has been
// annotated to indicate that it is okay to update it.
if val, ok := actual.Annotations[annotations.Update]; !ok || val != "enabled" {
if val, ok := actual.Annotations[annotations.Update]; !ok || val != annotations.EnabledVal {
return nil, false, nil
}

Expand Down
3 changes: 3 additions & 0 deletions pkg/k8sops/annotations/annotations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ const (
// Update is the annotation used by the operator to determine if a StatefulSet is
// allowed to be updated.
Update = "operator.m3db.io/update"

// EnabledVal is the value that indicates an annotation is enabled.
EnabledVal = "enabled"
)

// BaseAnnotations returns the base annotations we apply to all objects
Expand Down