Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#50 #101

Merged
merged 19 commits into from
May 9, 2022
Merged

Feature/#50 #101

merged 19 commits into from
May 9, 2022

Conversation

joocer
Copy link
Contributor

@joocer joocer commented May 9, 2022

[0.0.1] - 2022-05-09

Added

  • Additional statistics recording the time taken to scan partitions (@joocer)
  • FULL JOIN and RIGHT JOIN (@joocer)

Changed

  • Use PyArrow implementation for INNER JOIN and LEFT JOIN (@joocer)

Fixed

  • #99 Grouping by a list gives an unhelpful error message (@joocer)
  • #100 Projection ignores field qualifications (@joocer)

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

@ghost
Copy link

ghost commented May 9, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #101 (7a610ae) into main (be750e3) will increase coverage by 0.79%.
The diff coverage is 96.21%.

❗ Current head 7a610ae differs from pull request most recent head 2e3ceac. Consider uploading reports for the commit 2e3ceac to get more accurate results

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   90.43%   91.22%   +0.79%     
==========================================
  Files          67       69       +2     
  Lines        2508     2496      -12     
==========================================
+ Hits         2268     2277       +9     
+ Misses        240      219      -21     
Impacted Files Coverage Δ
opteryx/engine/functions/__init__.py 88.70% <ø> (+6.35%) ⬆️
opteryx/engine/functions/date_functions.py 70.58% <ø> (+11.49%) ⬆️
...pteryx/engine/planner/operations/base_plan_node.py 90.90% <ø> (+14.43%) ⬆️
...x/engine/planner/operations/dataset_reader_node.py 94.06% <ø> (+1.21%) ⬆️
opteryx/engine/planner/operations/distinct_node.py 89.47% <ø> (+9.47%) ⬆️
...teryx/engine/planner/operations/evaluation_node.py 95.74% <ø> (+3.58%) ⬆️
opteryx/engine/planner/operations/explain_node.py 100.00% <ø> (+12.50%) ⬆️
opteryx/engine/planner/operations/limit_node.py 96.00% <ø> (+6.34%) ⬆️
opteryx/engine/planner/operations/offset_node.py 90.90% <ø> (+6.29%) ⬆️
...pteryx/engine/planner/operations/selection_node.py 90.47% <ø> (-0.35%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a21ea0...2e3ceac. Read the comment docs.

@joocer joocer merged commit 13c0ddb into main May 9, 2022
@joocer joocer deleted the FEATURE/#50 branch May 9, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant