Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Laravel 5 support #31

Closed
wants to merge 2 commits into from
Closed

Laravel 5 support #31

wants to merge 2 commits into from

Conversation

stayallive
Copy link

Title says it all, this however would require this PR to be merged (machuga/authority#27) and the version to be changed in the composer.json for this PR.

@machuga
Copy link
Owner

machuga commented Feb 19, 2015

So I wholly love the idea of this and the removal if the config-file-esque service provider usage, but I'm not sure putting into master is great yet. I might need to branch off for L4 support

@stayallive
Copy link
Author

Whichever way you wish to go 👍

@RomainLanz
Copy link

What do you think of renaming your package to laravel-authority? And set 2 branches, one named 4.0 and one named 5.0.

Would be better for updating your package after that IMO.
You can still have this one on packagist and create a new repository.

@machuga
Copy link
Owner

machuga commented Feb 22, 2015

Branching is likely fine. I think github will forward requests to a renamed repo for X amount of time but I can't remember. I'd be fine with authority-laravel as the name.

@stokic
Copy link

stokic commented Feb 24, 2015

New package name and additional L4 branch would be great!

@tortuetorche
Copy link

@machuga Do you plan to merge this pull request soon?
If you don't have much time, it'll be easier to merge it in a l5 branch.
Then we can do this: composer require machuga/authority-l4:dev-l5 to install it.

@machuga
Copy link
Owner

machuga commented Mar 16, 2015

Ya doing it to a branch will be best because I don't want to break L4 anyway

@stayallive stayallive closed this Mar 24, 2015
@stayallive stayallive deleted the feature/laravel-5 branch March 24, 2015 11:19
@stayallive
Copy link
Author

@machuga how would you like to handle this one? Maybe open a new repo for L5 (following the "naming convention" of this package? Or just branch and alias on packagist?

I think leaving any authority-l4 traces (that the user will need to type) will be confusing, although you could also integrate the serviceprovider in the main Authority package.

@machuga
Copy link
Owner

machuga commented Mar 24, 2015

I try to keep all the of the Laravel specific stuff out of the main repo since it's framework agnostic. In the 3.0 release, if I ever release it, the event system is removed as well.

I feel like renaming this repo to authority-laravel with an l4 and l5 branch may be a good way to do it. Thoughts?

@stokic
Copy link

stokic commented Mar 24, 2015

IMO that's a good idea, rename and 2 branches

@stayallive
Copy link
Author

Big fan 👍 (also of a possible 3.0 of Authority)

@tortuetorche
Copy link

IMO, the repository renaming is not the priority but a l5 branch, based on the @stayallive work, will be really helpful.

@machuga
Copy link
Owner

machuga commented Mar 25, 2015

@stayallive do you have any interest in managing an authority-laravel repo? This one has always been managed by someone else (Conar Welsh) and I don't have time to properly invest in it.

@RomainLanz
Copy link

I'm going to create an ACL system like your but I'll allow user to store permission on the database and use the system of Middleware to set directly on the route file permission.

@machuga
Copy link
Owner

machuga commented Mar 25, 2015

@RomainLanz You might want to check out Lock - I think it lets you do that out of the box

@RomainLanz
Copy link

I already have check https://github.com/kodeine/laravel-acl but it's seems to young for the moment.

I'll look at Lock, thanks!

@stayallive
Copy link
Author

@machuga, I would certainly not object :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants