-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
So I wholly love the idea of this and the removal if the config-file-esque service provider usage, but I'm not sure putting into master is great yet. I might need to branch off for L4 support |
Whichever way you wish to go 👍 |
What do you think of renaming your package to laravel-authority? And set 2 branches, one named 4.0 and one named 5.0. Would be better for updating your package after that IMO. |
Branching is likely fine. I think github will forward requests to a renamed repo for X amount of time but I can't remember. I'd be fine with authority-laravel as the name. |
New package name and additional L4 branch would be great! |
@machuga Do you plan to merge this pull request soon? |
Ya doing it to a branch will be best because I don't want to break L4 anyway |
@machuga how would you like to handle this one? Maybe open a new repo for L5 (following the "naming convention" of this package? Or just branch and alias on packagist? I think leaving any authority-l4 traces (that the user will need to type) will be confusing, although you could also integrate the serviceprovider in the main Authority package. |
I try to keep all the of the Laravel specific stuff out of the main repo since it's framework agnostic. In the 3.0 release, if I ever release it, the event system is removed as well. I feel like renaming this repo to authority-laravel with an l4 and l5 branch may be a good way to do it. Thoughts? |
IMO that's a good idea, rename and 2 branches |
Big fan 👍 (also of a possible 3.0 of Authority) |
IMO, the repository renaming is not the priority but a |
@stayallive do you have any interest in managing an authority-laravel repo? This one has always been managed by someone else (Conar Welsh) and I don't have time to properly invest in it. |
I'm going to create an ACL system like your but I'll allow user to store permission on the database and use the system of Middleware to set directly on the route file permission. |
@RomainLanz You might want to check out Lock - I think it lets you do that out of the box |
I already have check https://github.com/kodeine/laravel-acl but it's seems to young for the moment. I'll look at Lock, thanks! |
@machuga, I would certainly not object :) |
Title says it all, this however would require this PR to be merged (machuga/authority#27) and the version to be changed in the composer.json for this PR.