This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
Laravel 5 support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing due to PHP 5.3 Incompatibility |
|
Oh right, we would have to bump this to 5.4 minimum since L5 does this... any problems with that? |
|
Yes please update and merge, I also had to fork in order to install. |
|
As-is I cannot merge it since it's breaking the build. 2.x supports 5.3, but 3.0 won't have to. |
|
@stayallive if you bump the version number to 5.4.0, update the travis.yml file to remove 5.3 and add whatever new php versions there are, I'll merge this in and mark it as a minor version release. Since you're the one motivating me to make this happen I want to make sure you get the credit in the commit history. :) |
|
I have updated the travis file to use the one Laravel uses, hope that's cool with you :) |
|
Thanks! |
|
Cooll.. L5 welcome 🍡 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.