Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified SKU based utils to Platform based utils #5

Closed
wants to merge 293 commits into from

Conversation

madhanmellanox
Copy link
Owner

  • What I did
    I moved all the SKU based variables (dictionaries), functions to Platform based variables and functions in scripts like sfputil.py, chassis.py, psu.py, fan.py and thermal.py

  • How I did it
    I eliminated almost all the references of SKU based dictionaries and functions from these files and instead used Platform based dictionaries and functions.

  • How to verify it
    Used the following commands to verify my changes are working:
    sudo sfputil show presence
    show platform psustatus
    show interface transceiver eeprom Ethernet0
    show platform temperature

  • Description for the changelog

The changes are only in files sfputil.py, chassis.py, fan.py, psu.py and thermal.py and the changes are conversion of dictionaries and functions from SKU based to Platform based.

- A picture of a cute animal (not mandatory but encouraged)

lguohan and others added 30 commits April 17, 2020 04:51
in buster, by default, rsyslog service does not create pidfile which
breaks monit configuration

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
from 3.7.3.3-3 to 3.7.3.3-4
Fixes for PFC WD

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
console means the vga port. this is mainly used for virtual environment such as hyper-v or virtualbox where you have the virtual vga port to display the boot up process.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
add $(BLDENV) in cache flags for following targets:

- $(SONIC_MAKE_DEBS)
- $(SONIC_DPKG_DEBS)
- $(SONIC_ONLINE_DEBS)
- $(SONIC_COPY_DEBS)
- $(SONIC_MAKE_FILES)

This is because we could build a same package for both
base image and docker which can be different os distribution,
i.e., buster v.s. stretch.

- target/debs/buster/swig3.0_3.0.12-2_amd64.deb
- target/debs/stretch/swig3.0_3.0.12-2_amd64.deb

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Added DPKG support for ICCPD package
Added warning support for missing dependency files that causes the incorrect SHA generation.
[baseimage]: upgrade base image to debian buster

bring up the base image to debian buster 4.19 kernel.

using the merge commits to preserve the individual commits to better track the history.
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
This patch set implements the following:
 - Fixes the conflicts in chassis.py / platform.py in sonic_platfrom
 - Consolidating the common library files in sonic_platform
 - Moving QFX5210 specific drivers to qfx5210/modules
 - Moving Juniper common fpga drivers to common/modules
 - Cleaning up the platform driver files
 - Bug fixes in QFX5210 platform monitor & initialiazation script
 - Fixing the bugs in QFX5210 eeprom parsing

Signed-off-by: Ciju Rajan K <crajank@juniper.net>
…onic-net#4426)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
it is important to understand the motivation of the PR.

what I did is usually the PR title, so remove.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
hardware daemons are not supported in kvm vs platform now

admin@vlab-01:/usr/share/sonic/device/x86_64-kvm_x86_64-r0$ docker exec -it pmon bash   
root@vlab-01:/# supervisorctl status
fancontrol                       STOPPED   Not started
lm-sensors                       STOPPED   Not started
rsyslogd                         RUNNING   pid 23, uptime 0:03:09
start.sh                         EXITED    Apr 22 09:07 AM
supervisor-proc-exit-listener    RUNNING   pid 17, uptime 0:03:10

Signed-off-by: Guohan Lu <lguohan@gmail.com>
- add led_proc_init.soc
- update config.bcm
…et#4105)

Co-authored-by: Jostar Yang <jostar_yang@accton.com.tw>
The one big bgp configuration template was splitted into chunks.

Currently we have three types of bgp neighbor peers:

general bgp peers. They are represented by CONFIG_DB::BGP_NEIGHBOR table entries
dynamic bgp peers. They are represented by CONFIG_DB::BGP_PEER_RANGE table entries
monitors bgp peers. They are represented by CONFIG_DB::BGP_MONITORS table entries
This PR introduces three templates for each peer type:

bgp policies: represent policieas that will be applied to the bgp peer-group (ip prefix-lists, route-maps, etc)
bgp peer-group: represent bgp peer group which has common configuration for the bgp peer type and uses bgp routing policy from the previous item
bgp peer-group instance: represent bgp configuration, which will be used to instatiate a bgp peer-group for the bgp peer-type. Usually this one is simple, consist of the referral to the bgp peer-group, bgp peer description and bgp peer ip address.
This PR redefined constant.yml file. Now this file has a setting for to use or don't use bgp_neighbor metadata. This file has more parameters for now, which are not used. They will be used in the next iteration of bgpcfgd.

Currently all tests have been disabled. I'm going to create next PR with the tests right after this PR is merged.

I'm going to introduce better bgpcfgd in a short time. It will include support of dynamic changes for the templates.

FIX:: sonic-net#4231
jleveque and others added 26 commits June 9, 2020 21:04
- Add .gitignore files in each subdirectory of src/, so as to reduce the size of the .gitignore file in the project root, and also make it easier to maintain (i.e., if a directory in src/ is removed, there will not be outdated entries in the root .gitignore file.

- Also add missing .gitignore entries and remove outdated entries and duplicates.
Signed-off-by: Danny Allen <daall@microsoft.com>
Found another syncd timing issue related to clock going backwards.
To be safe disable the ntp long jump.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
spytest requires higher paramiko version. Fix it to 2.7.1.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
The `-sv2` suffix was used to differentiate SNMP Dockers when we transitioned from "SONiCv1" to "SONiCv2", about four years ago. The old Docker materials were removed long ago; there is no need to keep this suffix. Removing it aligns the name with all the other Dockers.

Also edit Monit configuration to detect proper snmp-subagent command line in Buster, and make snmpd command line matching more robust.
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
* Set radvd version to match buster version(2.17-2)

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
**- Why I did it**
To ensure telemetry service is enabled by default after installing a fresh SONiC image

**- How I did it**
Set telemetry feature status to "enabled" when generating init_cfg.json file
Switching to Flannel from Calico which brings down the image size by around 500+MB.
* Support rw files allowlist for Sonic Secure Boot
* Improve the performance
* fix bug
* Move the config description into a md file
* Change to use a simple way to remove the blank line
* Support chmod a-x in rw folder
* Change function name
* Change some unnecessary words
* src/sonic-utilities 5765570...a21e01a (13):
  > [config] Don't attempt to restart disabled services (sonic-net#944)
  > [crm] Use swsssdk API instead of redis-cli for getting keys from redis DB (sonic-net#943)
  > Fixed fast-reboot for BFN platform (sonic-net#871)
  > [sfputil] Add support of platform.json (sonic-net#767)
  > [show] Add support for SONiC Gearbox Manager via new gearboxutil utility (sonic-net#931)
  > [warm-reboot]: added pre-check for ISSU file (sonic-net#915)
  > Add_intf_range (sonic-net#913)
  > add fec config/show option (sonic-net#764)
  > Make sure db_migrator is run after all config are loaded during (sonic-net#926)
  > Changes to make lldp show command for multi-npu platforms. (sonic-net#914)
  > [showtech]: add knet dump information in show tech (sonic-net#925)
  > Vnet alias mapping (sonic-net#924)
  > Revert the change to kdump reboot (sonic-net#916)
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>
…onic-net#4767)

* fix redistribution connected for ipv6 also

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
…net#4687)

* [Mellanox] Update hw-mgmt package to V.7.0010.1000

* update sonic-linux-kernel pointer to pick up new patch
- Alphabetize dependencies to prevent duplicates
- Remove unneccesary git clone

Signed-off-by: Danny Allen <daall@microsoft.com>
@madhanmellanox
Copy link
Owner Author

This is an internal PR and when trying to raise a PR, it got polluted with so many commits, so closing this PR.

madhanmellanox pushed a commit that referenced this pull request Jan 17, 2021
This update brings in the following commits.

86c1108 Enable arm architecture to build in addition to amd64 (sonic-net#37)
4acb2c3 fix bugs and enhance Transformer (sonic-net#35)
49e5a22 ygot related enhancements and fixes (sonic-net#34)
51224de Fix ietf yang search path for cvl schema builds (sonic-net#32)
3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (sonic-net#31)
dabf231 CVL Changes #7: 'leafref' evaluation (sonic-net#28)
6f9535f CVL Changes #6: Customized Xpath Engine integration (sonic-net#27)
5e2466b DB-Layer fixes/enhancements (sonic-net#26)
9a27302 CVL Changes #4: Implementation of new CVL APIs (sonic-net#22)
dbf1093 Translib support for authorization, yang versioning and Delete flag (sonic-net#21)
80f369e CVL Changes #5: YParser enhancement (sonic-net#23)
904ce18 CVL Changes #3: Multi-db instance support (sonic-net#20)
9d24a34 CVL Changes #2:  YValidator infra changes for evaluating xpath expression (sonic-net#19)
f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (sonic-net#18)
4922601 Bulk and RPC API support in translib (#16)
1d730df RFC7895 yang module library implementation (#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.