Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minizip's iowin32 does not properly detect Windows Store / UWP #480

Closed
null77 opened this issue Mar 17, 2020 · 3 comments
Closed

minizip's iowin32 does not properly detect Windows Store / UWP #480

null77 opened this issue Mar 17, 2020 · 3 comments

Comments

@null77
Copy link

null77 commented Mar 17, 2020 •
edited
Loading

Currently iowin32 uses

// see Include/shared/winapifamily.h in the Windows Kit
#if defined(WINAPI_FAMILY_PARTITION) && (!(defined(IOWIN32_USING_WINRT_API)))
#if WINAPI_FAMILY_ONE_PARTITION(WINAPI_FAMILY, WINAPI_PARTITION_APP)
#define IOWIN32_USING_WINRT_API 1
#endif
#endif

However this code no longer works correctly to detect Windows Store/UWP. This should be updated to something like the following:

#if !defined(IOWIN32_USING_WINRT_API)
#if defined(WINAPI_FAMILY) && (WINAPI_FAMILY == WINAPI_FAMILY_APP)
#define IOWIN32_USING_WINRT_API 1
#endif
#endif
null77 added a commit to null77/zlib that referenced this issue Mar 17, 2020
@null77
Fix UWP detection in iowin32.c.
c7e1158 
Use WINAPI_FAMILY instead of WINAPI_FAMILY_PARTITION.

Fixes madler#480
@null77 null77 mentioned this issue Mar 17, 2020
Closed
@gabriellanzer
Copy link

I was having issues compiling ZLib with Conan on my Clang11+Win10 setup. The WINAPI_FAMILY_ONE_PARTITION was undefined, changing for your code fixed my issue. :D Thanks.

@tbeu
Copy link
Contributor

tbeu commented Mar 29, 2022

Seems to be addressed by ce12773.

@madler madler closed this as completed Mar 29, 2022
@gvollant
Copy link
Contributor

see #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix UWP detection in iowin32.c. null77/zlib
5 participants
@madler @null77 @gvollant @tbeu @gabriellanzer