Improve documentation and usage of -[NSString UTF8String]
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works because UTF8String returns a copy when called on mutable strings.
This should improve performance of using NSString's Display impl.
madsmtm
added
documentation
madsmtm
force-pushed
the
ns-string-as-str
branch
2 times, most recently
from
03c6fa4
to
f106e32
Compare
madsmtm
force-pushed
the
ns-string-as-str
branch
from
f106e32
to
b88db80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-[NSString UTF8String](or the equivalentNSString::as_str) is used several times in our implementation, but when transitioning to #563, we must ensure that this usage is still sound even if the string is interior mutable.Luckily, Foundation already ensures this for us by checking if the string is mutable in the implementation of
UTF8String(and does so since macOS 10.6, I checked by downloading and disassembling the old binaries), so we needn't worry here.