Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and usage of -[NSString UTF8String] #628

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Improve documentation and usage of -[NSString UTF8String] #628

merged 4 commits into from
Jun 13, 2024

Commits on Jun 6, 2024

  1. Add test for using NSString's Display and Debug impl while mutating it 

    This works because UTF8String returns a copy when called on mutable
strings.
    @madsmtm
    madsmtm committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bb74c99 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Skip UTF-8 check of NSStrings in release mode 

    This should improve performance of using NSString's Display impl.
    @madsmtm
    madsmtm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    66d9655 View commit details
    Browse the repository at this point in the history

  2. Prefer NSString::to_string over as_str in tests and examples

    @madsmtm
    madsmtm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    cca6a40 View commit details
    Browse the repository at this point in the history

  3. Document safety guarantees of NSString::as_str and its internals

    @madsmtm
    madsmtm committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b88db80 View commit details
    Browse the repository at this point in the history