Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-4264: Deliver patches for MSI #609

Merged
merged 8 commits into from
Oct 9, 2019
Merged

Conversation

shiftedreality
Copy link
Member

@shiftedreality shiftedreality commented Sep 23, 2019

Description

Backport of 2 issues:

Issue 1

Issue 2

Fixed Issues (if relevant)

  1. https://magento2.atlassian.net/browse/MAGECLOUD-4264

Manual testing scenarios

magento/inventory#2336

magento/inventory#2350

There is no test case targeting exactly this, as this is a purely performance improvement. Technically the system must behave absolutely similarly.
To make sure everything works we have gone through basic test cases on catalog browsing scenarios with installed MSI on default source and stock

If there is a technical ability it makes sense to check, that there are no excessive queries to inventory_stock_1 table when executing scenarios above

magento/inventory#2515

We do not have a 100% reproducible case for this scenario. It’s expected to fix inventory indexation in the case when most of the products in the system have excessively long SKUs
Scenarios above (for 2350) should work just fine to make sure that indexation is not broken by the change

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@shiftedreality
Copy link
Member Author

@akaplya @ishakhsuvarov please have a look at version constraints

@andriyShevtsov
Copy link
Contributor

@akaplya @ishakhsuvarov please review

@shiftedreality shiftedreality changed the base branch from 2002.0 to develop September 26, 2019 15:18
oshmyheliuk
oshmyheliuk previously approved these changes Sep 26, 2019
NadiyaS
NadiyaS previously approved these changes Sep 26, 2019
@YPyltiai YPyltiai added the Release: 2002.1.0 ECE-Tools Release label Sep 26, 2019
@mveeramneni mveeramneni added Progress: testing in progress PR/issue status and removed Progress: on hold PR/issue status Progress: review PR/Issue status labels Oct 1, 2019
@shiftedreality shiftedreality added Progress: on hold PR/issue status and removed Progress: testing in progress PR/issue status labels Oct 1, 2019
ishakhsuvarov
ishakhsuvarov previously approved these changes Oct 7, 2019
@shiftedreality shiftedreality removed the Progress: on hold PR/issue status label Oct 8, 2019
@andriyShevtsov andriyShevtsov self-assigned this Oct 8, 2019
@andriyShevtsov
Copy link
Contributor

QA approved

@shiftedreality shiftedreality added Progress: accept PR/issue status and removed Progress: testing in progress PR/issue status labels Oct 9, 2019
@shiftedreality shiftedreality merged commit d7c47a7 into develop Oct 9, 2019
@ghost
Copy link

ghost commented Oct 9, 2019

Hi @shiftedreality, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@shiftedreality shiftedreality deleted the MAGECLOUD-4264 branch October 9, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept PR/issue status Release: 2002.1.0 ECE-Tools Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants