-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAGECLOUD-4264: Deliver patches for MSI #609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@akaplya @ishakhsuvarov please have a look at version constraints |
@akaplya @ishakhsuvarov please review |
shiftedreality
added
Progress: on hold
PR/issue status
and removed
Release Line: 2002.0
labels
Sep 26, 2019
oshmyheliuk
previously approved these changes
Sep 26, 2019
NadiyaS
previously approved these changes
Sep 26, 2019
mveeramneni
added
Progress: testing in progress
PR/issue status
and removed
Progress: on hold
PR/issue status
Progress: review
PR/Issue status
labels
Oct 1, 2019
shiftedreality
added
Progress: on hold
PR/issue status
and removed
Progress: testing in progress
PR/issue status
labels
Oct 1, 2019
ishakhsuvarov
previously approved these changes
Oct 7, 2019
shiftedreality
dismissed stale reviews from ishakhsuvarov, NadiyaS, and oshmyheliuk
via
October 9, 2019 14:46
343c25e
oshmyheliuk
approved these changes
Oct 9, 2019
NadiyaS
approved these changes
Oct 9, 2019
QA approved |
shiftedreality
added
Progress: accept
PR/issue status
and removed
Progress: testing in progress
PR/issue status
labels
Oct 9, 2019
Hi @shiftedreality, thank you for your contribution! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of 2 issues:
Issue 1
Issue 2
Fixed Issues (if relevant)
Manual testing scenarios
magento/inventory#2336
magento/inventory#2350
There is no test case targeting exactly this, as this is a purely performance improvement. Technically the system must behave absolutely similarly.
To make sure everything works we have gone through basic test cases on catalog browsing scenarios with installed MSI on default source and stock
If there is a technical ability it makes sense to check, that there are no excessive queries to inventory_stock_1 table when executing scenarios above
magento/inventory#2515
We do not have a 100% reproducible case for this scenario. It’s expected to fix inventory indexation in the case when most of the products in the system have excessively long SKUs
Scenarios above (for 2350) should work just fine to make sure that indexation is not broken by the change
Contribution checklist