-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cart Items are not deleted after success checkout #1461
Comments
Just to add to this ticket. There is also a bug where things appear in the mini basket (and you don't complete the order) but when you go to the checkout it says your cart is empty, even though it still has items in your mini basket. |
Duplicate of #1418. Internal ticket: MAGETWO-37603 |
Hello, |
Same here, the problem still exists. |
Dear @mukdam, please elaborate this fix. Its not very clear how to apply this. |
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593 This method is executed on `controller_action_predispatch`. The outcome of the following controller will be affected by leaving `$this->checkoutSession->setLoadInactive` set `true`. After placing an order the `customer/section/load` page is called from the checkout overview page to update the minicart and messages sections. Because of the `controller_action_predispatch` and the passing of all checks in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` `setLoadInactive` is left set to true and the expired quote is loaded one more time in the minicart, resulting in expired quote data the browser storage for the success page to display. By the way, I saw this comment: ```php !$observer->getControllerAction() instanceof \Magento\Checkout\Controller\Onepage // persistent session does not expire on onepage checkout page to not spoil customer group id ``` customer/section/load is not a checkout onepage controller, but it most certainly is called in the checkout. So the check in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` does not fully fill the gap the way the comment implies.
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593
FYI, commit 9093ce9 wasn't carried over to 2.1.7 CE .. after changing the 2 files manually it worked perfectly. FYI # 2: I'm able to get away with just changing module-checkout/view/frontend/templates/success.phtml - just need the following lines before the final div:
|
Fixed issues: - MAGETWO-71215: [EAV] Junk attribute values created when scheduling new staging update
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593 (cherry picked from commit 9093ce9)
@magento-engcom-team This fix doesn't appear to be included in 2.2. Does it need to be ported? |
Hi @vinhtrau this already ported to 2.2-develop, issue not reproducible on 2.2-branch |
Is this new feature or is a bug?
The text was updated successfully, but these errors were encountered: