Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shipping cart is empty than also minicart display item [ Magento 2.0.0 ] #4460

Closed
parthviroja opened this issue May 11, 2016 · 10 comments
Closed

shipping cart is empty than also minicart display item [ Magento 2.0.0 ] #4460

parthviroja opened this issue May 11, 2016 · 10 comments
Assignees
@ishakhsuvarov
Labels
bug report Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update

Comments

@parthviroja
Copy link

i have install magento 2.0.0 on live server

when i have remove items from shipping cart, minicart not updated.

now i refresh page few times, than also minicart display item.

15
@maksek
Copy link
Contributor

maksek commented May 11, 2016

@parthviroja, looks like you have customized theme already, can you reproduce the same behavior on vanilla Magento 2.0.5 installation?

@parthviroja
Copy link
Author

parthviroja commented May 12, 2016 •
edited
Loading

Thanks @maksek,

Same Issue produce in 2.0.5 after upgrade from 2.0.0.

This issue produce when i add item in cart after 15 to 20 minute, when i open shipping cart page, this happens.

When i clean browser cache and history than, minicart display empty.

@parthviroja parthviroja reopened this May 12, 2016
@devhn
Copy link

devhn commented May 12, 2016 •
edited
Loading

Same problem here using a custom theme (2.0.5). This was also reproduced with clean install - theme default. Mostly it happens when submitting an order when minicart should be cleared but it still shows the same product altough the cart page shows no products.

@andidhouse
Copy link

Same problem here on 2.0.5 fresh install - no custom theme.
Seems to me that the minicart is not cleaned after the cart is cleaned.

We had this issue also on 2.0.0 and 2.0.2.

@ishakhsuvarov
Copy link
Contributor

@devhn Which payment method did you use when placing order?
@andidhouse Please provide more precise steps to reproduce the issue (how do you clean the cart, etc.) Thanks.

@andidhouse
Copy link

@ishakhsuvarov
Steps:

  1. put some times in the shopping cart
  2. wait some time (in our case and settings half an our)
  3. the shopping cart page is empty - BUT the minicar is not empty but having the articles stored

@ishakhsuvarov
Copy link
Contributor

@andidhouse Steps you described look similar to the ones in #4416 I'm pretty sure it is the same case. We currently have a similar item in our backlog with the internal id MAGETWO-52593.

@ishakhsuvarov ishakhsuvarov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 26, 2016
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jul 13, 2016
Fix minicart not cleared after order completion
a5bc70f 
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593

This method is executed on `controller_action_predispatch`. The outcome of the following controller will be affected by leaving `$this->checkoutSession->setLoadInactive` set `true`.

After placing an order the `customer/section/load` page is called from the checkout overview page to update the minicart and messages sections. Because of the `controller_action_predispatch` and the passing of all checks in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` `setLoadInactive` is left set to true and the expired quote is loaded one more time in the minicart, resulting in expired quote data the browser storage for the success page to display.

By the way, I saw this comment:

```php
!$observer->getControllerAction() instanceof \Magento\Checkout\Controller\Onepage
// persistent session does not expire on onepage checkout page to not spoil customer group id
```

customer/section/load is not a checkout onepage controller, but it most certainly is called in the checkout. So the check in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` does not fully fill the gap the way the comment implies.
@AntonEvers AntonEvers mentioned this issue Jul 13, 2016
Closed
AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Jul 26, 2016
Fix minicart not cleared after order completion
9093ce9 
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593
@AntonEvers AntonEvers mentioned this issue Jul 26, 2016
Closed
@vkorotun vkorotun removed the CS label Aug 4, 2016
@veloraven
Copy link
Contributor

@parthviroja the internal issues was already fixed in commit c2bbe72 and closed.
Please let us know if your issue is fixed or still reproduces (in case it had different cause).

@andimov
Copy link
Contributor

andimov commented Sep 14, 2016

The contributor guide suggests that tickets that have not been active for two weeks should be closed. Please reopen as needed.

@andimov andimov closed this as completed Sep 14, 2016
@winds1983
Copy link

Still happened on 2.1.6, how to fix this?

AntonEvers pushed a commit to AntonEvers/magento2 that referenced this issue Sep 10, 2017
Fix minicart not cleared after order completion
36bebae 
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593

(cherry picked from commit 9093ce9)
@AntonEvers AntonEvers mentioned this issue Sep 10, 2017
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bug report Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@maksek @winds1983 @andimov @sdzhepa @veloraven @ishakhsuvarov @vkorotun @parthviroja @andidhouse @devhn