Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Standardize on Block naming conventions #231

Closed
jiggliemon opened this issue Feb 19, 2013 · 3 comments
Closed

Please Standardize on Block naming conventions #231

jiggliemon opened this issue Feb 19, 2013 · 3 comments

Comments

@jiggliemon
Copy link

Some of your block names are exported with dots while others are exported using underscores. It's anti-intuitive.
https://github.com/magento/magento2/blob/master/app/code/core/Mage/Catalog/view/frontend/layout.xml#L51
https://github.com/magento/magento2/blob/master/app/code/core/Mage/Catalog/view/frontend/layout.xml#L64

In v1.x, there was even camel case names.

@jiggliemon
Copy link
Author

I would recommend sticking with the dot notation, so as not to confuse search/replace in templates with the parent PHP class names.

@magento-team
Copy link
Contributor

@jiggliemon
Actually, there is a non-formal convention to use dot notation. To make it formal, the following needs to be done:

  • Replace everywhere into dots
  • Enforce the convention with an integrity test. The dev/tests/static/testsuite/Integrity/LayoutTest.php seems a good place for it.

Would you mind contributing?

@magento-team
Copy link
Contributor

Closing due to no activity. Please comment if you plan to provide a pull request with this change.

magento-team pushed a commit that referenced this issue Apr 20, 2015
magento-team pushed a commit that referenced this issue Dec 22, 2015
mmansoor-magento pushed a commit that referenced this issue Aug 9, 2016
…ETWO-55229-Problem-while-upgrading-210

[Fearless Kiwis] MAGETWO-55229: Problem while upgrading to 2.1.0
magento-devops-reposync-svc pushed a commit that referenced this issue Apr 29, 2024
…lable stock is lower than the quantity of the product (#231)
magento-devops-reposync-svc pushed a commit that referenced this issue Jun 27, 2024
…lable stock is lower than the quantity of the product (#231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants