-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please Standardize on Block naming conventions #231
Comments
I would recommend sticking with the dot notation, so as not to confuse search/replace in templates with the parent PHP class names. |
@jiggliemon
Would you mind contributing? |
Closing due to no activity. Please comment if you plan to provide a pull request with this change. |
mmansoor-magento
pushed a commit
that referenced
this issue
Aug 9, 2016
…ETWO-55229-Problem-while-upgrading-210 [Fearless Kiwis] MAGETWO-55229: Problem while upgrading to 2.1.0
magento-devops-reposync-svc
pushed a commit
that referenced
this issue
Apr 29, 2024
…lable stock is lower than the quantity of the product (#231)
magento-devops-reposync-svc
pushed a commit
that referenced
this issue
Jun 27, 2024
…lable stock is lower than the quantity of the product (#231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of your block names are exported with dots while others are exported using underscores. It's anti-intuitive.
https://github.com/magento/magento2/blob/master/app/code/core/Mage/Catalog/view/frontend/layout.xml#L51
https://github.com/magento/magento2/blob/master/app/code/core/Mage/Catalog/view/frontend/layout.xml#L64
In v1.x, there was even camel case names.
The text was updated successfully, but these errors were encountered: