Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catalog product price rules should be moved to controller/model #34

Closed
markshust opened this issue Jul 2, 2012 · 1 comment
Closed

Catalog product price rules should be moved to controller/model #34

markshust opened this issue Jul 2, 2012 · 1 comment

Comments

@markshust
Copy link
Contributor

The following template page contains too much code:

https://github.com/magento/magento2/blob/master/app/code/core/Mage/Catalog/view/frontend/product/price.phtml
@magento-team
Copy link
Contributor

Thank you for the suggestion, @markoshust.
We added two stories to our road map:

  • Reduced Catalog Component Dependencies
  • Simplified Prices Calculation

We're going to make refactoring of this and similar templates, make it simpler and take calculating logic out from the templates in scope of the above stories.

@SunshineTech SunshineTech mentioned this issue Dec 5, 2013
Closed
@drexlma drexlma mentioned this issue Jun 12, 2014
Closed
@leeyisoft leeyisoft mentioned this issue Jun 14, 2014
Closed
This was referenced Nov 22, 2014
Closed
Closed
Closed
@Crustymd Crustymd mentioned this issue Dec 11, 2014
Closed
magento-team pushed a commit that referenced this issue Jan 16, 2015
@vpelipenko
Merge pull request #34 from magento-extensibility/MAGETWO-31968-Logge…
5dde4a3 
…r-Fatal-Error

[Extensibility] Magetwo 31968 logger fatal error
@SKovbel SKovbel mentioned this issue Jan 31, 2015
Closed
@madhur99 madhur99 mentioned this issue Feb 22, 2015
Closed
@berliozd berliozd mentioned this issue Feb 27, 2015
Closed
@stevieyu stevieyu mentioned this issue Apr 3, 2015
Closed
@sivajik34 sivajik34 mentioned this issue Apr 15, 2015
Closed
magento-team pushed a commit that referenced this issue Apr 20, 2015
@slavvka
Merge pull request #231 from magento-south/BUGS
d4f4da9 
[South] Sprint #34 Bug fixes
@yukoff yukoff mentioned this issue May 4, 2015
Closed
@phphphp phphphp mentioned this issue May 29, 2015
Closed
@pccomfrank pccomfrank mentioned this issue Jun 2, 2015
Closed
@vinhtrau vinhtrau mentioned this issue Jul 4, 2015
Closed
@sivajik34 sivajik34 mentioned this issue Jul 13, 2015
Closed
@ljrweb ljrweb mentioned this issue Sep 9, 2015
Closed
@LifeAsBook LifeAsBook mentioned this issue Sep 10, 2015
Closed
@chrom chrom mentioned this issue Oct 7, 2015
Closed
@cfcnn cfcnn mentioned this issue Oct 11, 2015
Closed
okorshenko pushed a commit that referenced this issue Oct 23, 2015
Merge pull request #34 from magento-south/BUGS
00d0fe9 
[SOUTH] Bugfixes
@chaluvadiswamy chaluvadiswamy mentioned this issue Nov 3, 2015
Closed
This was referenced Nov 22, 2015
Closed
Closed
@thomvanderboon thomvanderboon mentioned this issue Nov 29, 2015
Closed
@primafair primafair mentioned this issue Nov 2, 2020
Closed
@mohanwbsofttech mohanwbsofttech mentioned this issue Dec 30, 2020
Closed
magento-engcom-team pushed a commit that referenced this issue May 18, 2021
@jcuerdo
MC-41988: JQMIGRATE jQXHR old functions are deprecated and removed (#34)
69cebe6 
- Fix new-video-dialog
@eBusinessAtlantique eBusinessAtlantique mentioned this issue May 20, 2021
Closed
@jpillai88 jpillai88 mentioned this issue May 21, 2021
Closed
@shinkhantmaung shinkhantmaung mentioned this issue Jun 20, 2021
Closed
@mtjweb mtjweb mentioned this issue Jun 25, 2021
Closed
5 tasks
@ghost ghost mentioned this issue Jun 28, 2021
Closed
1 task
This was referenced Jul 19, 2021
Merged
Closed
@chequille chequille mentioned this issue Aug 20, 2021
Closed
5 tasks
@Green2Matter Green2Matter mentioned this issue Jan 20, 2022
Closed
4 tasks
@jorgb90 jorgb90 mentioned this issue Apr 29, 2022
Closed
5 tasks
@pmonosolo pmonosolo mentioned this issue Aug 9, 2022
Closed
5 tasks
@ghost ghost mentioned this issue Aug 10, 2022
Closed
5 tasks
@ghost ghost mentioned this issue Aug 19, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 7, 2022
Closed
5 tasks
@mohammedTBB mohammedTBB mentioned this issue Sep 15, 2022
Closed
5 tasks
@pmonosolo pmonosolo mentioned this issue Nov 14, 2022
Closed
5 tasks
This was referenced Feb 17, 2023
Open
Closed
@kisfelix kisfelix mentioned this issue Apr 4, 2023
Closed
5 tasks
@Hexmage Hexmage mentioned this issue Jul 11, 2023
Closed
5 tasks
@KhanBadshah588 KhanBadshah588 mentioned this issue Oct 6, 2023
Closed
5 tasks
Closed
5 tasks
@iranimij iranimij mentioned this issue Nov 21, 2023
Closed
5 tasks
@AndeeKnitsLTD AndeeKnitsLTD mentioned this issue May 1, 2024
Closed
5 tasks
@shakeblue shakeblue mentioned this issue May 31, 2024
Closed
5 tasks
@aurel5542 aurel5542 mentioned this issue Jun 29, 2024
Closed
5 tasks
@FabXav FabXav mentioned this issue Oct 11, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshust @magento-team