Categories Path for Product URLs not working, issue with getProductUrl on Catalog Module? #2619
Comments
|
The command php bin/magento indexer:reindex changes nothing. In the table 'catalog_url_rewrite_product_category' there are no changes... |
|
Yes having the same issue "getProductUrl() isn't returning a URL with the category in the path in the catalog pages" |
|
Hi, @tigerx7. Thanks for reporting the issue! We've created an internal ticket MAGETWO-46927 to process it. |
vkholoshenko
added
Issue: Ready for Work
|
Good to hear. I've been studying the code trying to get my head around it by following the creation of the URL path in the catalog models. I got as far as getUrl() in \Magento\Catalog\Model\Product\Url. I'm able to confirm the following values in my test setup right before an instance of \Magento\Framework\UrlFactory gets created on the last line: $storeId = 1, $routePath = "catalog/product/view", $routeParams = ['id' => 39, 's' => 'prod-url-key', 'category' => 7, 'query' => []]. At that point it passes off to \Magento\Framework\UrlFactory and that's as far as I got. The parameters seem right, but I'm fairly new to Magento development and wouldn't consider myself too well versed just yet. |
|
I did a bit more digging. It seems that $product->hasUrlDataObject() is returning false and so is $product->getRequestPath() in function getUrl so UrlRewrite and setRequestPath never kick in. When ignoring the false check if statement on $product->getRequestPath(), the following $filterData gets formed in my test: [filterData] => Array
(
[entity_id] => 62
[entity_type] => product
[store_id] => 1
[metadata] => Array
(
[category_id] => 5
)
)However, when that gets passed to $this->urlFinder->findOneByData($filterData); it returns NULL The product id is correct (62) and it is in category_id 5, which is 3 levels deep. |
|
I did it working this way |
|
@GeromeF , I'm experiencing the same issue without sample data loaded. The urlrewrites are correct and I'm able to to load products when typing the rewritten url directly (ie. {domain}/{category}/{subcategory}/{product_url_key}. It brings up the product successfully. However, the url's that are being generated for the products when they're being listed at the category level and use catalog path in url is set to true are failing and generating something like: http://{domain}/catalog/product/view/id/1/s/{product_url_key}/category/4/ Are you able to reproduce successful URL's with the catalog path in the product list anchor tags at the catalog level? |
|
While tracking down another issue, I think I found the problem with the Product URL paths. getProductUrl isn't taking into account categories set as anchors. So say if a product is only assigned to the last child category: {default category}-->{level 1}->{level 2}->{level 3}. If a visitor navigates all the way to {level 3}, then the path for the product is generated correctly: {domain}/{level 1}/{level 2}/{level 3}/{product url key}. However, if {level 2} is set as an anchor, and the visitor only navigates that far, then that's when getUrlPath() fails and generates the non-url-rewrite path for a product. |
|
Sorry for the delay. First issue was fixed in e0f560f. And for issue from your last comment we've created one more internal ticket: MAGETWO-47656 |
|
@vladimir-k Awesome, I was able to confirm that applying e0f560f fixed the issue for category assigned products. It's one step closer, now it's just the anchor categories having the url path issue. Applying the mentioned changes didn't fix the issue in anchor categories. |
|
Whenever we are creating product from Admin, it is doing an insert in "url_rewrite" table(magento2), after doing reindexing it is working fine on the front end. But when we are importing products from csv, then it is creating wrong url's like "catalog/product/view" etc. Even after reindexing its not working. Also we have noticed, its not doing any insert in "url_rewrite" when doing reindexing. We have noticed that its only inserting into "url_rewrite" when doing insert from admin. Is it default feature of magento now? |
|
@pravalitera i've modified the script, according your comment. The strange thing is that the regenerated url's don't have the store view value's, but the main store value's after regeneration. I'm digging in the DB now to find out more... |
|
@Tjitse-E I think it's because when the table "url_rewrite" is already generated, you fall into the "catch" of the insert (duplicate). You have "-" instead of "." when you launch it. I will repost asap with a proper script that does everything right, i'm dealing with another things right now. I'm just astonished that i have to rewrite something to reindex urls... |
|
Ok. Here is a new version that rewrite products and category.
in Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator; l.109
$productCategories = $product->getCategoryCollection()
->addAttributeToSelect('url_key')
->addAttributeToSelect('url_path')
->setStore($storeId) // Line to add !!!
;If you don't do that, the product will not have the proper category path by stores... My new script : /**
* CLI Command to Reindex URLS
*
*
* @author RAVALITERA Pol <pol.ravalitera@gmail.com>
* @author Tjitse <@github>
* @author kanduvisla <@github>
* @author miro91 <@github>
* @version 0.0.1
*/
namespace Afg\Core\Console\UrlRewriting;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Magento\UrlRewrite\Model\UrlPersistInterface;
use Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator;
/**
* Class RegenerateUrls.php
*/
class RegenerateUrls extends Command
{
/**
* @var \Magento\Store\Model\StoreManagerInterface
*/
protected $storeManager;
/**
* @var \Magento\UrlRewrite\Model\UrlRewriteFactory
*/
protected $urlRewriteFactory;
/**
* @var CategoryUrlRewriteGenerator
*/
protected $categoryUrlRewriteGenerator;
/**
* @var UrlPersistInterface
*/
protected $urlPersist;
/**
* @var \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory
*/
protected $categoryCollectionFactory;
/**
* @var \Magento\CatalogUrlRewrite\Observer\UrlRewriteHandler
*/
protected $urlRewriteHandler;
/**
* RegenerateUrls constructor.
* @param \Magento\UrlRewrite\Model\UrlRewriteFactory $urlRewriteFactory
* @param \Magento\Store\Model\StoreManagerInterface $storeManager
* @param \Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryCollectionFactory
* @param string $name
*/
public function __construct(
\Magento\UrlRewrite\Model\UrlRewriteFactory $urlRewriteFactory,
\Magento\Store\Model\StoreManagerInterface $storeManager,
\Magento\CatalogUrlRewrite\Model\CategoryUrlRewriteGenerator $categoryUrlRewriteGenerator,
\Magento\Catalog\Model\ResourceModel\Category\CollectionFactory $categoryCollectionFactory,
UrlPersistInterface $urlPersist,
\Magento\CatalogUrlRewrite\Observer\UrlRewriteHandler $urlRewriteHandler,
$name = 'regenerate_urls'
)
{
$this->urlRewriteFactory = $urlRewriteFactory;
$this->storeManager = $storeManager;
$this->categoryUrlRewriteGenerator = $categoryUrlRewriteGenerator;
$this->categoryCollectionFactory = $categoryCollectionFactory;
$this->urlPersist = $urlPersist;
$this->urlRewriteHandler = $urlRewriteHandler;
parent::__construct($name);
}
/**
* Configure the command
*/
protected function configure()
{
$this->setName('afg:rewrite_url:category2');
$this->setDescription('Regenerate Url\'s for categories');
}
/**
* @param InputInterface $input
* @param OutputInterface $output
*/
protected function execute(InputInterface $input, OutputInterface $output)
{
if ($this->storeManager->isSingleStoreMode()) {
$stores = [$this->storeManager->getStore(0)];
} else {
$stores = $this->storeManager->getStores();
}
$start_time = microtime(true);
foreach ($stores as $store) {
$output->writeln($store->getCode().'...');
$categories = $this->categoryCollectionFactory->create()->setStore($store->getId())
->addAttributeToSelect(array('url_key', 'url_path', 'is_anchor'))
->addAttributeToFilter('level', 2)
->addAttributeToFilter('parent_id',$store->getRootCategoryId())
;
foreach ($categories as $category) {
if ($category->getUrlKey()) {
$category->setStoreId($store->getId());
$urlRewrites = array_merge(
$this->categoryUrlRewriteGenerator->generate($category, true)
, $this->urlRewriteHandler->generateProductUrlRewrites($category)
);
$this->urlPersist->replace($urlRewrites);
}
}
}
$output->writeln('[DONE] ' . round(microtime(true) - $start_time,2) .' sec');
}
}
|
|
@Tristan-N there is the code I use in a custom admin route And you need to inject |
|
@Gael42 The $storeManager->setCurrentStore() handle the bug i speak about just over, in Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator Still a bug to me, but it handles it, thx. I think your code will just be impossible to run on my website: i have more than 100 000 products ! If it's like in Magento 1, the collection will make the script go out of memory :( i'll try ! And i don't understand the "delete" part: the replace already does that. (Edit: ah ok, to delete even if we moved a product) @iazel code does not work out of the box : when i do the setup:upgrade , i have: I had to comment the $state->setAreaCode('adminhtml'); to setup, then decomment it after... Weird. I imported my 100 000 products with a modified Magmi i have done... A shame that there is no more url indexer... |
|
@pravalitera @iazel code works on my store without problems. Although i'm using a slightly older version of https://github.com/Iazel/magento2-regenurl. All the product url's are generated perfectly on each store view (i've tested with 12 store views). Thanks for your efforts! @pravalitera i've tested your last generation code (including the fix in Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator), on a multistore with 10 store-views in multiple languages. But the RegenerateUrls script seems to mess up the new category rewrites. The store value's just seem random. I've got category URL's like: www.mainsite.com/English_url/Url_ Francais/. Do you have the same problems? Steps that i've taken to test the script:
|
|
@Tjitse-E It seems ok on my side... i dunno why... My scripts does not handle product that are not in any categories, that's why @lazel's script was slower than mine... Stupid i am ^^ I just have a question: How many products do you have in your base ? Because making a collection of 100 000 products is a big deal i think. And the big flaw that we have is that it does not handle 301 redirection for old url... But i think I know how to make it... |
|
@pravalitera we only have 300 products, 60 categories and 10 store views in different languages, so no big deal there. We've corrected the category rewrites manually, so the problem for this client is resolved. But it would be nice if Magento solves this in 2.2... |
|
Incase this helps anyone. I truncated the url_rewrite table.
thanks for this thread, helped a bunch. cheers! |
|
@pravalitera , you said "And the big flaw that we have is that it does not handle 301 redirection for old url... But i think I know how to make it..." Did you find how to do it ? This would be a nice feature ! Thank you :) |
|
juat wanted to stop by and say thanks @iazel you sir are a life saver. |
|
I have experienced a similar issue on 2.1.5. All migrated products work fine and creating new products works fine (URLs correctly formatted) but, if I use the duplicate feature the product url is formatted incorrectly. No imports. Migrated from 1.9 to 2.1.2. Correct site URLS Incorrect product URL (made by using Save & Duplicate) If I manually type in: Admin settings |
|
Is this issue still there in Version 2.1.7 , cause it is pretty annoying. |
|
@skast96 That's correct. However we turned off 'Use Categories Path for Product URLs' and now the canonical url is used. That works, but the strange thing is that half of the products have correct url's and the other half don't when enabling the option again. All our products are inserted by hand, so there should be no problem creating url keys. |
|
@Jeordy thank you for your answer, I have been thinking about this issue quiet a while, and came to the conclusion that i just load a collection with one particular product in it and call the addRewriteUrl function on it. It's the easiest way I thought of and it works really well. The best way would be adding this method to the product itself if someone, like me, just needs one particular product url. |
|
@skast96 We've solved the issue with some help. It seems we changed the dbStorage with a Github fix that isn't a fix. We reverted this 'fix' and used a module called: URL Rewrite Regeneration from ThLassche (https://marketplace.magento.com/thlassche-regeneraterewrites.html). Great module and I advise you to buy and use it. Great support too from ThLassche himself. |
|
@magento-engcom-team could you provide the pull request in where this is fixed so I can create a back-port for 2.1 and 2.2 branches. Or provide me the back-port if it already exists :) |
|
Since it is magento and version 2.3 has been released there is still no solution for this matter? |
[TSG] Backporting for 2.2 (pr28) (2.2.5)
|
@koopjesboom We are using Enterprise 2.3.5-p2 and the problem is still not fixed. If I execute |
|
@Eddcapone: Magento 2 doesn't generate url rewrites with indexers, Magento 1 did that, but Magento 2 has no official way to regenerate url rewrites.
This module might also be useful to find incorrect data in the url data of your catalog btw: |
|
@hostep, Thank you for the info. Do you know why they removed the feature from M2? How are we officialy supposed to auto generate URL Rewrites now without using a 3rd party extension? I thought M2 is supposed to be better than M1. I tried https://github.com/olegkoval/magento2-regenerate_url_rewrites but it does not generate category urls. I will try the others though. Thanks! |
|
It's bad for SEO if you regenerate a bunch of url rewrites without then also generating 301 redirects from the old to the new url. I think that was the main thought when they rebuild the system for M2. But never saw such an official statement being made, this is only guessing here. I do agree that it's a feature missing in M2 in certain cases, for example when you aren't in production yet and are building your store and tweaking settings/data to try out various ways of setting up url's. Then it would be handy if you could regenerate all url rewrites to make them consistent. Unfortunately you need 3rd party modules to do this. In theory all changes should always cause correct url rewrites to be generated (including 301 redirects if you ask for it), but there are way too many bugs in M2 where this fails, from time to time such a bug gets fixed but it goes very slowly and there are still a bunch of bugs open I believe. Good luck with your endeavours! The url rewrite problems in M2 are probably one of the most frustrating things I had to deal with so far. |
I have used this Oleg Koval Extension and yes it generates the URL's for the category urls. If not use separate commands for products and categories: $> php bin/magento ok:urlrewrites:regenerate --entity-type=category All the commands you can find here: https://github.com/olegkoval/magento2-regenerate_url_rewrites I do not know if there is dry run in this olegkoval extension, if not this should a default feature. |
|
I'm seriously starting to see M1 as better than M2 to develop for. Current Magento introduce a lot of unnecessary complexity (specially at front-end level, KnockoutJS + RequireJS absolutely sucks) and now even removes widely used features such as this. I seriously hope that M3 will came and solve this issues, being a powerful e-commerce platform that the developers could actually developer for it instead of losing a bunch of time with such trivial things or fighting against it. 🤦♂️ |
|
@ivanaugustobd I understand you, I was also at this point. Even extremly simple customisations can take hours and sometimes days because you have to figure everything out and the documentation is very bad and misses beginner examples. But the longer you work with it, the more you will understand its benefits. |
and others
It seems that getProductUrl() isn't returning a URL with the category in the path in the catalog pages. I'm able to reproduce this with a clean install using my own data and a clean install using the sample data.
Steps:
URL Rewrite is functioning since "gear/bags/joust-duffle-bag.html" is in the url_rewrite DB table and http:///gear/bags/joust-duffle-bag.html successfully pulls up the product page. It just seems there's an issue with getProductUrl() on the catalog module inserting the category correctly; unless I have a misunderstanding on something?
The text was updated successfully, but these errors were encountered: