-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issues with url rewrites created on shop with multiple storeviews #7667
Conversation
…d when utilizing the url rewrite functionality programmatically.
Looks like integration tests are not working. Access denied for user 'root'@'localhost' (using password: NO) |
…ors while saving category in adminhtml.
I just updated the PR, my initial commit started giving problems when saving a category in the backend which then threw Would be great if this PR can get some extensive testing, because I'm not total sure if this won't have negative effects elsewhere. |
And added a third commit for yet another issue we ran into. Also: I know the CI tests fail, but I only tested these changes on 2.1.2 and not on the develop branch, I just copied the changes into the new |
…fix it...", it seems to be doing more bad then good... This reverts commit 159f12c.
…t-UrlRewriteMap-develop-final MAGETWO-58924 - Url rewrite map table lock
I'm giving up on this, the fixes are never 100% correct in all different cases in which url rewrites can be generated. |
We have a project where we import a bunch of categories and products programmatically.
And after that we let the url rewrites being created as this doesn't seem to happen automatically.
In Magento 2.1.2, there are problems in the category urls when we do this, where the url's use the url_key from the category data from store id 0 (admin values) instead of from the specific storeview we try to generate the url rewrites for.
This PR fixes our issues.
Possibly related to #4112 and #2619