Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Regression in 2.2 - menu.xml config ignored #10543

Merged

Conversation

fooman
Copy link
Contributor

@fooman fooman commented Aug 16, 2017

Description

Fixes regression introduced with commit fooman@24b608a
dependsOnModule, dependsOnConfig, toolTip should match casing mandated by menu.xsd
please also note which already has the correct values.

Manual testing scenarios

  1. setup a module with
    <!--menu.xml-->
    <?xml version="1.0"?>
    <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Backend:etc/menu.xsd">
        <menu>
            <add id="Fooman_Example::test"
                 parent="Magento_Sales::sales"
                 resource="Fooman_Example::test"
                 module="Fooman_Example"
                 title="Fooman Example"
                 sortOrder="20"
                 action="foomanexample/test"
                 dependsOnConfig="foomanexample/menu/display_test"/>
        </menu>
    </config>
  1. Make sure foomanexample/menu/display_test is a false value
  2. Observe that the menu item is not visible

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@fooman fooman force-pushed the fix/backend-menu-ignored-config branch from 1ed760f to c0cd601 Compare August 16, 2017 10:27
@ishakhsuvarov ishakhsuvarov self-assigned this Aug 16, 2017
@ishakhsuvarov ishakhsuvarov added this to the August 2017 milestone Aug 16, 2017
@magento-team magento-team merged commit c0cd601 into magento:develop Aug 18, 2017
magento-team pushed a commit that referenced this pull request Aug 18, 2017
[EngCom] Public Pull Requests
 - MAGETWO-71659: Fix for url_rewrite on page delete via api #10568
 - MAGETWO-71617: Fixes Regression in 2.2 - menu.xml config ignored #10543
 - MAGETWO-71380: Fix JS translation search #10445
 - MAGETWO-71201: Improved calculating version hash for the js-translation.json file. #10378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants