Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#9720 Menu item dependencies (dependsOnModule, depend… #12747

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

hannassy
Copy link

@hannassy hannassy commented Dec 15, 2017

Description

dependsOnModule, dependsOnConfig, toolTip should match casing mandated by menu.xsd
please also note which already has the correct values.

Fixed issues

#9720: Menu item dependencies

Manual testing scenarios

  1. setup a module with
    <!--menu.xml-->
    <?xml version="1.0"?>
    <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Backend:etc/menu.xsd">
        <menu>
            <add id="Fooman_Example::test"
                 parent="Magento_Sales::sales"
                 resource="Fooman_Example::test"
                 module="Fooman_Example"
                 title="Fooman Example"
                 sortOrder="20"
                 action="foomanexample/test"
                 dependsOnConfig="foomanexample/menu/display_test"/>
        </menu>
    </config>
  1. Make sure foomanexample/menu/display_test is a false value
  2. Observe that the menu item is not visible

Backport of #10543

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov
Copy link
Contributor

ishakhsuvarov commented Dec 15, 2017

Hi @hannassy
This seems to be a backport of #10543
Please port also changes introduced to the tests so that all of them pass.
Also, PR description complete with test scenarios would be really appreciated

@hannassy
Copy link
Author

@ishakhsuvarov
Tests added

@magento-engcom-team magento-engcom-team added bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line mageconf Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Dec 15, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Dec 18, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 18, 2017
@magento-team magento-team merged commit ddf6c9f into magento:2.2-develop Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants