Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issues with url rewrites created on shop with multiple storeviews #7667

Closed
wants to merge 5 commits into from
Closed

Fixes issues with url rewrites created on shop with multiple storeviews #7667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a64eb4
Fixes issue with url rewrites being generated using the wrong store i…
baldwinagency-pieter Dec 2, 2016
70445f9
Fixes problems with 'URL key for specified store already exists.' err…
baldwinagency-pieter Dec 5, 2016
897c518
Fixed incorrect camelCased variable name.
baldwinagency-pieter Dec 5, 2016
159f12c
Yet another issue discoverd with url rewrites, this seems to fix it...
baldwinagency-pieter Dec 8, 2016
ce35129
Revert "Yet another issue discoverd with url rewrites, this seems to …
hostep Dec 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/CatalogUrlRewrite/Model/Product/AnchorUrlRewriteGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function generate($storeId, Product $product, ObjectRegistry $productCate
$anchorCategoryIds = $category->getAnchorsAbove();
if ($anchorCategoryIds) {
foreach ($anchorCategoryIds as $anchorCategoryId) {
$anchorCategory = $this->categoryRepository->get($anchorCategoryId);
$anchorCategory = $this->categoryRepository->get($anchorCategoryId, $storeId);
$urls[] = $this->urlRewriteFactory->create()
->setEntityType(ProductUrlRewriteGenerator::ENTITY_TYPE)
->setEntityId($product->getId())
Expand Down
7 changes: 6 additions & 1 deletion app/code/Magento/CatalogUrlRewrite/Model/ProductScopeRewriteGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,12 @@ public function generateForGlobalScope($productCategories, Product $product)
if (!$this->isGlobalScope($id)
&& !$this->storeViewService->doesEntityHaveOverriddenUrlKeyForStore($id, $productId, Product::ENTITY)
) {
$urls = array_merge($urls, $this->generateForSpecificStoreView($id, $productCategories, $product));
// before loading the category collection by looping it, clone it and set the correct store id,
// so we get the correct url_path & url_key for that specific store id
$storeSpecificProductCategories = clone $productCategories;
$storeSpecificProductCategories->setStoreId($id);

$urls = array_merge($urls, $this->generateForSpecificStoreView($id, $storeSpecificProductCategories, $product));
}
}

Expand Down