Fix unused dependency check and remove unused dependencies #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 10, 2021 12:20
We should pin by default to ensure CI remains stable. We may want to add security advisory checking for GitHub Actions in future, to prompt us to update.
The `test-utils` feature is required for benchmarks and some examples, and their dependencies are not counted if the feature is not enabled.
connec
changed the title
This is a slightly speculative fix based on https://gh.neting.ccmunity/t/189130 and rust-lang/cargo#9695. Although it seems this may have been fixed/worked around in cargo, the latest version of `cargo-udeps` still depends on cargo 0.54.0 which could be affected.
jacderida
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ba18457 ci: Pin specific SHA for
aig787/cargo-udeps-actionWe should pin by default to ensure CI remains stable. We may want to add
security advisory checking for GitHub Actions in future, to prompt us to
update.
4bb18e5 ci: Use
test-utilsfeature when running udepsThe
test-utilsfeature is required for benchmarks and some examples,and their dependencies are not counted if the feature is not enabled.
0e0dcbf chore: Remove unused dependencies
c9631d0 ci: Pin specific nightly for cargo udeps job
This is a slightly speculative fix based on
https://gh.neting.ccmunity/t/189130 and
Flag another curl error as possibly spurious rust-lang/cargo#9695. Although it seems this may
have been fixed/worked around in cargo, the latest version of
cargo-udepsstill depends on cargo 0.54.0 which could be affected.